[M] Change in coreboot[main]: mb/amd/birman_plus/ec: Rectify ECRAM register bits

[Ana Carolina Cabral (Code Review)]

Ana Carolina Cabral has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/86084?usp=email )

Change subject: mb/amd/birman_plus/ec: Rectify ECRAM register bits
......................................................................

Patch Set 14:

(6 comments)

File src/mainboard/amd/birman_plus/ec.c:

https://review.coreboot.org/c/coreboot/+/86084/comment/c0b9a636_ec15bf9c?usp... :
PS13, Line 11: #define EC_GPIO_0_ADDR		0xA0
> the defines are added, but not used in the code; is this intended?

I thought about only enabling 19V if the eval card was present, but when I saw it was configurable I was not so sure. Added it to this patch.

https://review.coreboot.org/c/coreboot/+/86084/comment/d923f27d_158ac1e9?usp... :
PS13, Line 36: _N
> i don't think that this one is inverted. sure, the signal on the m. […]

Done

https://review.coreboot.org/c/coreboot/+/86084/comment/926679f0_853efc80?usp... :
PS13, Line 127: EC7_WL_RADIO_DIS_N
> see my comment on the register bit; i'd expect this one needing to be cleared, not set

Done

https://review.coreboot.org/c/coreboot/+/86084/comment/bf1796c8_d196ae24?usp... :
PS13, Line 138: 	tmp = ECA_MUX1_S0 | ECA_SMBUS1_EN | ECA_SMBUS0_EN;
> would probably be good to configure the other muxes here too

Done

https://review.coreboot.org/c/coreboot/+/86084/comment/17bfa07e_5712fcb1?usp... :
PS13, Line 142: 	tmp = ec_read(EC_GPIO_6_ADDR);
              : 	tmp |= EC6_TPNL_BUF_EN | EC6_TPAD_BUF_EN;
              : 	printk(BIOS_SPEW, "Write reg [0x%02x] = 0x%02x\n", EC_GPIO_6_ADDR, tmp);
              : 	ec_write(EC_GPIO_6_ADDR, tmp);
> i'd move this block between the ones for EC_GPIO_3_ADDR and EC_GPIO_7_ADDR

Done

https://review.coreboot.org/c/coreboot/+/86084/comment/c8e7d93a_ec4ebeb7?usp... :
PS13, Line 156: 	if (CONFIG(DISABLE_WWAN_GBE_BIRMANPLUS)) {	// no WWAN, turn off WWAN power
> i'd find it a bit easier to read when doing the bit clear/bit set in the if/else branches and not ha […]

Well, I personally prefer the default values being set first, but here you go..