Change in ...coreboot[master]: superio/fintek/f71863fg: Remove variable set but not used

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32990

Change subject: superio/fintek/f71863fg: Remove variable set but not used
......................................................................

superio/fintek/f71863fg: Remove variable set but not used

Change-Id: I993055d237b2bd607822485d34d5508c74a7744c
Signed-off-by: Elyes HAOUAS 
---
M src/superio/fintek/f71863fg/superio.c
1 file changed, 1 insertion(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/32990/1

diff --git a/src/superio/fintek/f71863fg/superio.c b/src/superio/fintek/f71863fg/superio.c
index 634888b..a5cd632 100644
--- a/src/superio/fintek/f71863fg/superio.c
+++ b/src/superio/fintek/f71863fg/superio.c
@@ -23,15 +23,13 @@

static void f71863fg_init(struct device *dev)
 {
-	struct resource *res0;
-
    if (!dev->enabled)
    	return;

switch (dev->path.pnp.device) {
    /* TODO: Might potentially need code for HWM or FDC etc. */
    case F71863FG_KBC:
-		res0 = find_resource(dev, PNP_IDX_IO0);
+		find_resource(dev, PNP_IDX_IO0);
    	pc_keyboard_init(NO_AUX_DEVICE);
    	break;
    }

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32990 )

Change subject: superio/fintek/f71863fg: Remove variable set but not used
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/32990/1/src/superio/fintek/f71863fg/superio.... 
File src/superio/fintek/f71863fg/superio.c:

https://review.coreboot.org/#/c/32990/1/src/superio/fintek/f71863fg/superio.... 
PS1, Line 32: 		find_resource(dev, PNP_IDX_IO0);
hmm, this function call is an "interesting" way to make sure that PNP_IDX_IO0 is set (the function calls die("") when it isn't)

[Felix Held (Code Review)]

Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32990 )

Change subject: superio/fintek/f71863fg: Remove variable set but not used
......................................................................

superio/fintek/f71863fg: Remove variable set but not used

Change-Id: I993055d237b2bd607822485d34d5508c74a7744c
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32990
Tested-by: build bot (Jenkins) 
Reviewed-by: Felix Held 
---
M src/superio/fintek/f71863fg/superio.c
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Held: Looks good to me, approved

diff --git a/src/superio/fintek/f71863fg/superio.c b/src/superio/fintek/f71863fg/superio.c
index 634888b..a5cd632 100644
--- a/src/superio/fintek/f71863fg/superio.c
+++ b/src/superio/fintek/f71863fg/superio.c
@@ -23,15 +23,13 @@

static void f71863fg_init(struct device *dev)
 {
-	struct resource *res0;
-
    if (!dev->enabled)
    	return;

switch (dev->path.pnp.device) {
    /* TODO: Might potentially need code for HWM or FDC etc. */
    case F71863FG_KBC:
-		res0 = find_resource(dev, PNP_IDX_IO0);
+		find_resource(dev, PNP_IDX_IO0);
    	pc_keyboard_init(NO_AUX_DEVICE);
    	break;
    }