Change in coreboot[master]: mb/google/volteer: Add support for passive USB-C daughterboard

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42905 )

Change subject: mb/google/volteer: Add support for passive USB-C daughterboard
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42905/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/volteer/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/42905/1/src/mainboard/google/voltee... 
PS1, Line 159: 						device generic 1 on
             : 							probe DB_USB USB4_GEN2
             : 							probe DB_USB USB3_ACTIVE
             : 							probe DB_USB USB4_GEN3
             : 							probe DB_USB USB3_NO_A
             : 						end
             : 					end
             : 					chip drivers/intel/pmc_mux/con
             : 						register "usb2_port_number" = "4"
             : 						register "usb3_port_number" = "2"
             : 						# SBU & HSL follow CC
             : 						device generic 1 on
             : 							probe DB_USB USB3_PASSIVE
             : 						end
> i'm open to suggestions - don't you then have to walk the device tree and "fix" […]

You would need to get a few device references yes and fix up the values, roughly:

dev = get_connector_device_for_port();
config = dev->chip_info;
if (!fw_config_probe(DB_USB, USB3_PASSIVE))
    config->sbu_orientation = TYPEC_ORIENTATION_NORMAL;

although if we don't anticipate it being used much, maybe it's not so bad