Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36527 )
Change subject: timestamps: COLLECT_TIMESTAMPS is always optional ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36527/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36527/3//COMMIT_MSG@14 PS3, Line 14: the use of get_us_since_boot() with COLLECT_TIMESTAMPS=n.
Why is it that there is an increase in those conditions?
The code changes from 'has 5 seconds from power-on elapsed' to 'lets wait here for 5 seconds'.
https://review.coreboot.org/c/coreboot/+/36527/3//COMMIT_MSG@15 PS3, Line 15: We could implement get_us_since_boot() over monotonic timer.
Currently monotonic timer is relative to the stage. It's not global and free running. […]
I doubt if amd/stoneyridge/monotonic_timer.c version does the same. Or intel/quark/tsc_freq.c. Or nvidia/tegra210/monotonic_timer.c.
Probably something that was never defined?
-
Kyösti Mälkki (Code Review)