View Change
2 comments:
Commit Message:
Patch Set #3, Line 14: the use of get_us_since_boot() with COLLECT_TIMESTAMPS=n.
Why is it that there is an increase in those conditions?
The code changes from 'has 5 seconds from power-on elapsed' to 'lets wait here for 5 seconds'.
Patch Set #3, Line 15: We could implement get_us_since_boot() over monotonic timer.
Currently monotonic timer is relative to the stage. It's not global and free running. […]
I doubt if amd/stoneyridge/monotonic_timer.c version does the same. Or intel/quark/tsc_freq.c. Or nvidia/tegra210/monotonic_timer.c.
Probably something that was never defined?
To view, visit change 36527. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ee4195d266440143344781d39db9578cd8bdcb3
Gerrit-Change-Number: 36527
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Comment-Date: Fri, 01 Nov 2019 17:59:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin <adurbin@chromium.org>
Gerrit-MessageType: comment