Attention is currently required from: Maulik V Vaghela, Paul Menzel, Subrata Banik, Ronak Kanabar, Aamir Bohra.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45905 )
Change subject: drivers/intel/fsp2_0: Integrate FirmwareVersionInfo.h
......................................................................
Patch Set 12:
(1 comment)
File src/drivers/intel/fsp2_0/Kconfig.debug_blob:
https://review.coreboot.org/c/coreboot/+/45905/comment/a39793da_80597c31
PS5, Line 46: using new header 'FirmwareVersionInfo.h'.
hi, i am confused here about the automatic detection how you are proposing here. can you please help me understand method you are suggesting
You can let Make check for the presence of a header file and
then add compilation options for the .c file. The latter can
be tricky because one has to construct the object file's path.
I guess something like this could work:
ifneq($(wildcard $(CONFIG_FSP_HEADER_PATH)/FirmwareVersionInfoHob.h),)
ramstage-y += version_info.c
$(call src-to-obj,$(dir)/version_info.c): CPPFLAGS_common += -include $(CONFIG_FSP_HEADER_PATH)/FirmwareVersionInfoHob.h -DFSP_VERSION_INFO_1
else ifneq($(wildcard $(CONFIG_FSP_HEADER_PATH)/FirmwareVersionInfo.h),)
ramstage-y += version_info.c
$(call src-to-obj,$(dir)/version_info.c): CPPFLAGS_common += -include $(CONFIG_FSP_HEADER_PATH)/FirmwareVersionInfo.h -DFSP_VERSION_INFO_2
endif
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45905
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50f7cae9ed4fac60f91d86bdd3e884956627e4b5
Gerrit-Change-Number: 45905
Gerrit-PatchSet: 12
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Comment-Date: Tue, 02 Feb 2021 14:13:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-MessageType: comment