Attention is currently required from: Arthur Heymans, Julius Werner, Martin L Roth, Nico Huber.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/81907?usp=email )
Change subject: util/lint: Add lint rule to avoid duplicated includes
......................................................................
Patch Set 5:
(1 comment)
File util/lint/lint-stable-031-includes:
https://review.coreboot.org/c/coreboot/+/81907/comment/7ee54566_f0e838d1?usp... :
PS5, Line 56: check_duplicates '<arch/pci_ops.h>' '<device/pci_ops.h>'
I guess if we want to enforce things, we'd first have to decide on the rules? […]
about <string.h>, I found it here https://review.coreboot.org/c/coreboot/+/39468
You are right, we need a rules for that.
The patch I've sent is based on 'IWYU pragma: export' comments in coreboot tree.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81907?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia14c73f0bffa6ee4b73254d71836f793af8771c4
Gerrit-Change-Number: 81907
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 26 May 2024 20:14:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de