Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43818 )
Change subject: [WIP] soc/intel/apollolake: Drop select SMP ......................................................................
[WIP] soc/intel/apollolake: Drop select SMP
TBD: smp/atomic.h
Change-Id: Icb4c7551031f4e32e01198261ee9ae9b95f18142 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/intel/apollolake/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/43818/1
diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig index f837a2e..ba6febd 100644 --- a/src/soc/intel/apollolake/Kconfig +++ b/src/soc/intel/apollolake/Kconfig @@ -31,7 +31,6 @@ select CPU_INTEL_FIRMWARE_INTERFACE_TABLE select IOAPIC select PCR_COMMON_IOSF_1_0 - select SMP select SSE2 select SUPPORT_CPU_UCODE_IN_CBFS # Audio options
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43818 )
Change subject: [WIP] soc/intel/apollolake: Drop select SMP ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43818/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43818/1//COMMIT_MSG@7 PS1, Line 7: [WIP] soc/intel/apollolake: Drop select SMP intel/apollolake_rvp and intel/minnow3 do not specify the MAX_CPUS value.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43818 )
Change subject: [WIP] soc/intel/apollolake: Drop select SMP ......................................................................
Patch Set 1:
Werner, Mario: Can you comment about MAX_CPUS with APL?
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43818 )
Change subject: [WIP] soc/intel/apollolake: Drop select SMP ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43818/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43818/1//COMMIT_MSG@7 PS1, Line 7: [WIP] soc/intel/apollolake: Drop select SMP
intel/apollolake_rvp and intel/minnow3 do not specify the MAX_CPUS value.
Which seems wrong, unless there is single-core SKU on those.
Anyways with smp=N there is a real error with <smp/atomic.h> and <arch/smp/atomic.h> that this build showcases.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43818 )
Change subject: [WIP] soc/intel/apollolake: Drop select SMP ......................................................................
Patch Set 1:
Patch Set 1:
Werner, Mario: Can you comment about MAX_CPUS with APL?
https://ark.intel.com/content/www/us/en/ark/products/codename/80644/apollo-l...
Intel says either two or four CPU cores, no HyperThreading. So all but UP Squared are wrong, I think.
Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43818 )
Change subject: [WIP] soc/intel/apollolake: Drop select SMP ......................................................................
Abandoned
Kyösti Mälkki has restored this change. ( https://review.coreboot.org/c/coreboot/+/43818 )
Change subject: [WIP] soc/intel/apollolake: Drop select SMP ......................................................................
Restored
Hello build bot (Jenkins), Mario Scheithauer, Werner Zeh, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43818
to look at the new patch set (#3).
Change subject: soc/intel/apollolake: Drop select SMP ......................................................................
soc/intel/apollolake: Drop select SMP
The SOC has MAX_CPUS>1 so this is redundant.
Change-Id: Icb4c7551031f4e32e01198261ee9ae9b95f18142 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/intel/apollolake/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/43818/3
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43818 )
Change subject: soc/intel/apollolake: Drop select SMP ......................................................................
Patch Set 4: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43818 )
Change subject: soc/intel/apollolake: Drop select SMP ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43818/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43818/1//COMMIT_MSG@7 PS1, Line 7: [WIP] soc/intel/apollolake: Drop select SMP
Which seems wrong, unless there is single-core SKU on those. […]
soc/intel/apollolake setn MAX_CPUS now.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43818 )
Change subject: soc/intel/apollolake: Drop select SMP ......................................................................
Patch Set 4: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43818 )
Change subject: soc/intel/apollolake: Drop select SMP ......................................................................
soc/intel/apollolake: Drop select SMP
The SOC has MAX_CPUS>1 so this is redundant.
Change-Id: Icb4c7551031f4e32e01198261ee9ae9b95f18142 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43818 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/apollolake/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig index f7e4e59..a39e4bb 100644 --- a/src/soc/intel/apollolake/Kconfig +++ b/src/soc/intel/apollolake/Kconfig @@ -29,7 +29,6 @@ select CPU_INTEL_FIRMWARE_INTERFACE_TABLE select IOAPIC select PCR_COMMON_IOSF_1_0 - select SMP select SSE2 select SUPPORT_CPU_UCODE_IN_CBFS # Audio options
-
Angel Pons (Code Review) -
Kyösti Mälkki (Code Review)
-
Nico Huber (Code Review)