Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48381 )
Change subject: soc/intel/common/block/cpu/car: Make whitespace proper ......................................................................
soc/intel/common/block/cpu/car: Make whitespace proper
This patch removes unnecessary whitespace from IA common car code block.
Change-Id: I3690b5f219f5326cfca7956f21132062aa89648e Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/common/block/cpu/Kconfig M src/soc/intel/common/block/cpu/car/cache_as_ram.S 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/48381/1
diff --git a/src/soc/intel/common/block/cpu/Kconfig b/src/soc/intel/common/block/cpu/Kconfig index 9023b58..1ec7af5 100644 --- a/src/soc/intel/common/block/cpu/Kconfig +++ b/src/soc/intel/common/block/cpu/Kconfig @@ -64,7 +64,7 @@ select COS_MAPPED_TO_MSB help This config supports INTEL_CAR_NEM_ENHANCED mode on - TGL platform. + TGL platform.
config COS_MAPPED_TO_MSB bool diff --git a/src/soc/intel/common/block/cpu/car/cache_as_ram.S b/src/soc/intel/common/block/cpu/car/cache_as_ram.S index 167342f..97bffb0 100644 --- a/src/soc/intel/common/block/cpu/car/cache_as_ram.S +++ b/src/soc/intel/common/block/cpu/car/cache_as_ram.S @@ -413,7 +413,7 @@
set_eviction_mask: mov %ebx, %ecx /* back up the number of ways */ - mov %eax, %ebx /* back up the non-eviction mask*/ + mov %eax, %ebx /* back up the non-eviction mask */ /* * Set MSR 0xC91 IA32_L3_MASK_1 or MSR 0x1891 IA32_CR_SF_QOS_MASK_1 * This MSR contain one bit per each way of LLC
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48381
to look at the new patch set (#2).
Change subject: soc/intel/common/block/cpu/car: Make whitespace proper ......................................................................
soc/intel/common/block/cpu/car: Make whitespace proper
This patch removes unnecessary whitespace from IA common car code block.
Change-Id: I3690b5f219f5326cfca7956f21132062aa89648e Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/common/block/cpu/Kconfig M src/soc/intel/common/block/cpu/car/cache_as_ram.S 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/48381/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48381 )
Change subject: soc/intel/common/block/cpu/car: Make whitespace proper ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/48381/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48381/2//COMMIT_MSG@7 PS2, Line 7: soc/intel/common/block/cpu/car: Make whitespace proper Maybe: Fix two whitespace issues
https://review.coreboot.org/c/coreboot/+/48381/2//COMMIT_MSG@9 PS2, Line 9: removes It also adds a space. ;-)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48381 )
Change subject: soc/intel/common/block/cpu/car: Make whitespace proper ......................................................................
Patch Set 2: Code-Review+2
Hello build bot (Jenkins), Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48381
to look at the new patch set (#3).
Change subject: soc/intel/common/block/cpu/car: Fix two whitespace issues ......................................................................
soc/intel/common/block/cpu/car: Fix two whitespace issues
This patch removes 1 unnecessary whitespace and add 1 whitespace into IA common car code block.
Change-Id: I3690b5f219f5326cfca7956f21132062aa89648e Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/common/block/cpu/Kconfig M src/soc/intel/common/block/cpu/car/cache_as_ram.S 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/48381/3
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48381 )
Change subject: soc/intel/common/block/cpu/car: Fix two whitespace issues ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48381/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48381/2//COMMIT_MSG@7 PS2, Line 7: soc/intel/common/block/cpu/car: Make whitespace proper
Maybe: Fix two whitespace issues
Ack
https://review.coreboot.org/c/coreboot/+/48381/2//COMMIT_MSG@9 PS2, Line 9: removes
It also adds a space. […]
Ack
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48381 )
Change subject: soc/intel/common/block/cpu/car: Fix two whitespace issues ......................................................................
soc/intel/common/block/cpu/car: Fix two whitespace issues
This patch removes 1 unnecessary whitespace and add 1 whitespace into IA common car code block.
Change-Id: I3690b5f219f5326cfca7956f21132062aa89648e Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48381 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/common/block/cpu/Kconfig M src/soc/intel/common/block/cpu/car/cache_as_ram.S 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/common/block/cpu/Kconfig b/src/soc/intel/common/block/cpu/Kconfig index 9023b58..1ec7af5 100644 --- a/src/soc/intel/common/block/cpu/Kconfig +++ b/src/soc/intel/common/block/cpu/Kconfig @@ -64,7 +64,7 @@ select COS_MAPPED_TO_MSB help This config supports INTEL_CAR_NEM_ENHANCED mode on - TGL platform. + TGL platform.
config COS_MAPPED_TO_MSB bool diff --git a/src/soc/intel/common/block/cpu/car/cache_as_ram.S b/src/soc/intel/common/block/cpu/car/cache_as_ram.S index 167342f..97bffb0 100644 --- a/src/soc/intel/common/block/cpu/car/cache_as_ram.S +++ b/src/soc/intel/common/block/cpu/car/cache_as_ram.S @@ -413,7 +413,7 @@
set_eviction_mask: mov %ebx, %ecx /* back up the number of ways */ - mov %eax, %ebx /* back up the non-eviction mask*/ + mov %eax, %ebx /* back up the non-eviction mask */ /* * Set MSR 0xC91 IA32_L3_MASK_1 or MSR 0x1891 IA32_CR_SF_QOS_MASK_1 * This MSR contain one bit per each way of LLC
-
Angel Pons (Code Review) -
Paul Menzel (Code Review)
-
Subrata Banik (Code Review)