Attention is currently required from: Martin Roth. ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62404 )
Change subject: Revert "util/cbfstool: Port elogtool to libflashrom" ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3: I'm the one who forwarded the reports on this to Martin. Basically, on friday feb 25, we were unable to find a single upstream distro on which this would build. We had 5 engineers from 3 companies trying to see if anybody had any new distro on which this would build; none worked.
It's unlikely you want to ship in this state.
The problem is that even on the newest distros we tried (various ubuntu 20, popos, etc.) the libflashrom-dev is missing a prototype, so you get this error: /home/rminnich/AMD64/coreboot/util/cbfstool/uflashrom.c:113:3: error: implicit declaration of function ‘flashrom_layout_get_region_range’ [-Werror=implicit-function-declaration] 113 | flashrom_layout_get_region_range(layout, region, &r_start, &r_len);
This is going to hit every person who tries to build cbfstool from source. There doesn't seem to be a great workaround at present.
-
ron minnich (Code Review)