Change in coreboot[master]: drivers/ocp/dmi: Add OCP_DMI driver for populating SMBIOS from IPMI F...

[Johnny Lin (Code Review)]

Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40308 )

Change subject: drivers/ocp/dmi: Add OCP_DMI driver for populating SMBIOS from IPMI FRU data
......................................................................

Patch Set 52:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40308/51/src/drivers/ocp/dmi/smbios... 
File src/drivers/ocp/dmi/smbios.c:

https://review.coreboot.org/c/coreboot/+/40308/51/src/drivers/ocp/dmi/smbios... 
PS51, Line 176: 			*p+
> Why do we double null terminate here?

I simply use the same smbios_add_string() in arch/x86/smbios.c
https://review.coreboot.org/c/coreboot/+/42029/18/src/arch/x86/smbios.c#77
but removed the if condition at L98 because that doesn't allow me to add duplicate strings.
From the SMBIOS Spec DSP0134 Version 3.0.0, section 6.1.3:
"Each string is terminated with a null (00h) BYTE and the set of strings is terminated with an additional null (00h) BYTE."
I think always adding two null bytes can be used for both terminating an individual string and a set of strings.