Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30414 )
Change subject: mainboard/facebook/fbg1701: Do initial mainboard commit ......................................................................
Patch Set 12:
(4 comments)
https://review.coreboot.org/#/c/30414/12/Documentation/mainboard/facebook/fb... File Documentation/mainboard/facebook/fbg1701.md:
https://review.coreboot.org/#/c/30414/12/Documentation/mainboard/facebook/fb... PS12, Line 11: : A fully working image should be possible What does this mean?
https://review.coreboot.org/#/c/30414/12/Documentation/mainboard/facebook/fb... PS12, Line 39: Trailing space
https://review.coreboot.org/#/c/30414/12/Documentation/mainboard/facebook/fb... PS12, Line 43: DIP-8 Is it DIP-8? The linked datasheet mentions nothing about DIP-8. Maybe SOIC-8? (I don't know, I have not seen the mainboard)
https://review.coreboot.org/#/c/30414/12/Documentation/mainboard/facebook/fb... PS12, Line 48: 3.5V 3.3V I'd say
-
Angel Pons (Code Review)