Hello Kevin Chiu,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/35143
to review the following change.
Change subject: mb/google/octopus/variants/garg: update new SKU ......................................................................
mb/google/octopus/variants/garg: update new SKU
For Garg EVT build, add new SKU ID below: SKU4 LTE DB, touch: SKU ID - 18 SKU5,6 Convertible, 2A2C, Touch, Stylus, rear camera: SKU ID - 37
BUG=b:134854577 BRANCH=octopus TEST=emerge-octopus coreboot chromeos-bootimage Change-Id: Iea1d17efb9a5f274f8eefb2aaa683e75ab5de7d2 Signed-off-by: Kevin Chiu Kevin.Chiu@quantatw.com --- M src/mainboard/google/octopus/variants/garg/gpio.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/35143/1
diff --git a/src/mainboard/google/octopus/variants/garg/gpio.c b/src/mainboard/google/octopus/variants/garg/gpio.c index 36fde90..bcabac5 100644 --- a/src/mainboard/google/octopus/variants/garg/gpio.c +++ b/src/mainboard/google/octopus/variants/garg/gpio.c @@ -23,6 +23,8 @@ SKU_1_2A2C = 1, SKU_9_HDMI = 9, SKU_17_LTE = 17, + SKU_18_LTE_TS = 18, + SKU_37_2A2C_360 = 37, };
static const struct pad_config default_override_table[] = { @@ -84,6 +86,7 @@ *num = ARRAY_SIZE(hdmi_override_table); return hdmi_override_table; case SKU_17_LTE: + case SKU_18_LTE_TS: *num = ARRAY_SIZE(lte_override_table); return lte_override_table; default:
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35143 )
Change subject: mb/google/octopus/variants/garg: update new SKU ......................................................................
Patch Set 1: Code-Review+1
Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35143 )
Change subject: mb/google/octopus/variants/garg: update new SKU ......................................................................
Patch Set 1: Code-Review+1
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35143 )
Change subject: mb/google/octopus/variants/garg: update new SKU ......................................................................
Patch Set 1:
(1 comment)
The build bot error does not look related to this CL.
https://review.coreboot.org/c/coreboot/+/35143/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35143/1//COMMIT_MSG@15 PS1, Line 15: TEST=emerge-octopus coreboot chromeos-bootimage Can you add a blank line here.
Hello Sheng-Liang Pan, Karthik Ramasubramanian, Marco Chen, Kevin Chiu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35143
to look at the new patch set (#2).
Change subject: mb/google/octopus/variants/garg: update new SKU ......................................................................
mb/google/octopus/variants/garg: update new SKU
For Garg EVT build, add new SKU ID below: SKU4 LTE DB, touch: SKU ID - 18 SKU5,6 Convertible, 2A2C, Touch, Stylus, rear camera: SKU ID - 37
BUG=b:134854577 BRANCH=octopus TEST=emerge-octopus coreboot chromeos-bootimage
Change-Id: Iea1d17efb9a5f274f8eefb2aaa683e75ab5de7d2 Signed-off-by: Kevin Chiu Kevin.Chiu@quantatw.com --- M src/mainboard/google/octopus/variants/garg/gpio.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/35143/2
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35143 )
Change subject: mb/google/octopus/variants/garg: update new SKU ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35143/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35143/1//COMMIT_MSG@15 PS1, Line 15: TEST=emerge-octopus coreboot chromeos-bootimage
Can you add a blank line here.
Done
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35143 )
Change subject: mb/google/octopus/variants/garg: update new SKU ......................................................................
Patch Set 2: Code-Review+2
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35143 )
Change subject: mb/google/octopus/variants/garg: update new SKU ......................................................................
Patch Set 2:
add more reviewers for asking to merge the CL.
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35143 )
Change subject: mb/google/octopus/variants/garg: update new SKU ......................................................................
mb/google/octopus/variants/garg: update new SKU
For Garg EVT build, add new SKU ID below: SKU4 LTE DB, touch: SKU ID - 18 SKU5,6 Convertible, 2A2C, Touch, Stylus, rear camera: SKU ID - 37
BUG=b:134854577 BRANCH=octopus TEST=emerge-octopus coreboot chromeos-bootimage
Change-Id: Iea1d17efb9a5f274f8eefb2aaa683e75ab5de7d2 Signed-off-by: Kevin Chiu Kevin.Chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35143 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/octopus/variants/garg/gpio.c 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/garg/gpio.c b/src/mainboard/google/octopus/variants/garg/gpio.c index 36fde90..bcabac5 100644 --- a/src/mainboard/google/octopus/variants/garg/gpio.c +++ b/src/mainboard/google/octopus/variants/garg/gpio.c @@ -23,6 +23,8 @@ SKU_1_2A2C = 1, SKU_9_HDMI = 9, SKU_17_LTE = 17, + SKU_18_LTE_TS = 18, + SKU_37_2A2C_360 = 37, };
static const struct pad_config default_override_table[] = { @@ -84,6 +86,7 @@ *num = ARRAY_SIZE(hdmi_override_table); return hdmi_override_table; case SKU_17_LTE: + case SKU_18_LTE_TS: *num = ARRAY_SIZE(lte_override_table); return lte_override_table; default:
-
Furquan Shaikh (Code Review) -
Karthik Ramasubramanian (Code Review)
-
Kevin Chiu (Code Review)
-
Marco Chen (Code Review)
-
Sheng-Liang Pan (Code Review)