Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38168 )
Change subject: util/amdfwtool: Add instances for APCB backup ......................................................................
util/amdfwtool: Add instances for APCB backup
Match each of the possible APCB items with a corresponding backup APCB. A missing backup copy can prevent the system from booting.
Change-Id: I400194b2763239896214ea42cfe6fbeb8ed261a8 Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M util/amdfwtool/amdfwtool.c 1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/38168/1
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 02564cf..39cc45f 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -362,7 +362,11 @@ { .type = AMD_BIOS_APCB, .inst = 2, .level = BDT_BOTH }, { .type = AMD_BIOS_APCB, .inst = 3, .level = BDT_BOTH }, { .type = AMD_BIOS_APCB, .inst = 4, .level = BDT_BOTH }, - { .type = AMD_BIOS_APCB_BK, .level = BDT_BOTH }, + { .type = AMD_BIOS_APCB_BK, .inst = 0, .level = BDT_BOTH }, + { .type = AMD_BIOS_APCB_BK, .inst = 1, .level = BDT_BOTH }, + { .type = AMD_BIOS_APCB_BK, .inst = 2, .level = BDT_BOTH }, + { .type = AMD_BIOS_APCB_BK, .inst = 3, .level = BDT_BOTH }, + { .type = AMD_BIOS_APCB_BK, .inst = 4, .level = BDT_BOTH }, { .type = AMD_BIOS_APOB, .level = BDT_BOTH }, { .type = AMD_BIOS_BIN, .reset = 1, .copy = 1, .zlib = 1, .level = BDT_BOTH },
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38168 )
Change subject: util/amdfwtool: Add instances for APCB backup ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38168 )
Change subject: util/amdfwtool: Add instances for APCB backup ......................................................................
util/amdfwtool: Add instances for APCB backup
Match each of the possible APCB items with a corresponding backup APCB. A missing backup copy can prevent the system from booting.
Change-Id: I400194b2763239896214ea42cfe6fbeb8ed261a8 Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38168 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M util/amdfwtool/amdfwtool.c 1 file changed, 5 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 02564cf..39cc45f 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -362,7 +362,11 @@ { .type = AMD_BIOS_APCB, .inst = 2, .level = BDT_BOTH }, { .type = AMD_BIOS_APCB, .inst = 3, .level = BDT_BOTH }, { .type = AMD_BIOS_APCB, .inst = 4, .level = BDT_BOTH }, - { .type = AMD_BIOS_APCB_BK, .level = BDT_BOTH }, + { .type = AMD_BIOS_APCB_BK, .inst = 0, .level = BDT_BOTH }, + { .type = AMD_BIOS_APCB_BK, .inst = 1, .level = BDT_BOTH }, + { .type = AMD_BIOS_APCB_BK, .inst = 2, .level = BDT_BOTH }, + { .type = AMD_BIOS_APCB_BK, .inst = 3, .level = BDT_BOTH }, + { .type = AMD_BIOS_APCB_BK, .inst = 4, .level = BDT_BOTH }, { .type = AMD_BIOS_APOB, .level = BDT_BOTH }, { .type = AMD_BIOS_BIN, .reset = 1, .copy = 1, .zlib = 1, .level = BDT_BOTH },
-
Marshall Dawson (Code Review) -
Martin Roth (Code Review)