Change in ...coreboot[master]: soc/intel/skylake: Use real common code for VMX init

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29682 )

Change subject: soc/intel/skylake: Use real common code for VMX init
......................................................................

Patch Set 7:

(2 comments)

https://review.coreboot.org/#/c/29682/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/29682/7//COMMIT_MSG@9 
PS7, Line 9: Use the common VMX implementation, and set IA32_FEATURE_CONTROL
Thanks, fetched the wrong patch set... I wonder why they made the
patch set handling such awkward in the new UI.

https://review.coreboot.org/#/c/29682/7/src/soc/intel/skylake/cpu.c 
File src/soc/intel/skylake/cpu.c:

https://review.coreboot.org/#/c/29682/7/src/soc/intel/skylake/cpu.c@496 
PS7, Line 496: mp_run_on_all_cpus(vmx_configure, NULL, 2 * USECS_PER_MSEC);
             : 
             : 	mp_run_on_all_cpus(sgx_configure, NULL, 14 * USECS_PER_MSEC);
             : 
             : 	mp_run_on_all_cpus(fc_lock_configure, NULL, 2 * USECS_PER_MSEC);
> not the scope of this patch but why is it run in post_mp_init and not in the cpu_driver.ops. […]

SGX probably because of "requirements", the lock because of SGX,
but VMX could be set earlier.