Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48145 )
Change subject: mb/kontron/mal10: Use explicit includes ......................................................................
mb/kontron/mal10: Use explicit includes
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: I7b913da9ff085db7e6512d8714bfd2e5331e00bd --- M src/mainboard/kontron/mal10/carriers/t10-tni/gpio.c M src/mainboard/kontron/mal10/include/variant/gpio.h M src/mainboard/kontron/mal10/variants/mal10/gpio.c 3 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/48145/1
diff --git a/src/mainboard/kontron/mal10/carriers/t10-tni/gpio.c b/src/mainboard/kontron/mal10/carriers/t10-tni/gpio.c index 674b209..0419f9d 100644 --- a/src/mainboard/kontron/mal10/carriers/t10-tni/gpio.c +++ b/src/mainboard/kontron/mal10/carriers/t10-tni/gpio.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <carrier/gpio.h> +#include <gpio.h>
static const struct pad_config gpio_table[] = { PAD_CFG_GPIO_DRIVER_HI_Z(GPIO_0, DN_20K, DEEP, IGNORE, SAME), diff --git a/src/mainboard/kontron/mal10/include/variant/gpio.h b/src/mainboard/kontron/mal10/include/variant/gpio.h index ea942ca..ec53e4a 100644 --- a/src/mainboard/kontron/mal10/include/variant/gpio.h +++ b/src/mainboard/kontron/mal10/include/variant/gpio.h @@ -3,8 +3,6 @@ #ifndef MAL_10_CFG_GPIO_H #define MAL_10_CFG_GPIO_H
-#include <gpio.h> - void variant_early_gpio_configure(void);
#endif /* MAL_10_CFG_GPIO_H */ diff --git a/src/mainboard/kontron/mal10/variants/mal10/gpio.c b/src/mainboard/kontron/mal10/variants/mal10/gpio.c index 3986776..e81ba6b 100644 --- a/src/mainboard/kontron/mal10/variants/mal10/gpio.c +++ b/src/mainboard/kontron/mal10/variants/mal10/gpio.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
+#include <gpio.h> #include <variant/gpio.h>
static const struct pad_config gpio_table[] = {
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48145 )
Change subject: mb/kontron/mal10: Use explicit includes ......................................................................
Patch Set 2: Code-Review+1
Hello Nico Huber, Frans Hendriks, Maxim Polyakov,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48145
to look at the new patch set (#3).
Change subject: mb/kontron/mal10: Use explicit includes ......................................................................
mb/kontron/mal10: Use explicit includes
Built with BUILD_TIMELESS=1, coreboot.rom remains the same.
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: I7b913da9ff085db7e6512d8714bfd2e5331e00bd --- M src/mainboard/kontron/mal10/carriers/t10-tni/gpio.c M src/mainboard/kontron/mal10/include/variant/gpio.h M src/mainboard/kontron/mal10/variants/mal10/gpio.c 3 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/48145/3
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48145 )
Change subject: mb/kontron/mal10: Use explicit includes ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48145/4/src/mainboard/kontron/mal10... File src/mainboard/kontron/mal10/carriers/t10-tni/gpio.c:
https://review.coreboot.org/c/coreboot/+/48145/4/src/mainboard/kontron/mal10... PS4, Line 4: #include <gpio.h> I'm confused. What is it used for?
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48145 )
Change subject: mb/kontron/mal10: Use explicit includes ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48145/4/src/mainboard/kontron/mal10... File src/mainboard/kontron/mal10/carriers/t10-tni/gpio.c:
https://review.coreboot.org/c/coreboot/+/48145/4/src/mainboard/kontron/mal10... PS4, Line 4: #include <gpio.h>
I'm confused. […]
well, it's not explicit 😄 suggestion: use the explicit include "soc/gpio.h" here ;)
https://review.coreboot.org/c/coreboot/+/48145/4/src/mainboard/kontron/mal10... File src/mainboard/kontron/mal10/variants/mal10/gpio.c:
https://review.coreboot.org/c/coreboot/+/48145/4/src/mainboard/kontron/mal10... PS4, Line 3: gpio.h soc/gpio.h would be explicit ;)
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48145?usp=email )
Change subject: mb/kontron/mal10: Use explicit includes ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-
Felix Singer (Code Review) -
Frans Hendriks (Code Review)
-
Martin L Roth (Code Review)
-
Michael Niewöhner (Code Review)
-
Nico Huber (Code Review)