Attention is currently required from: Jérémy Compostella.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66917 )
Change subject: soc/intel/alderlake: Support Raptor Lake VR Fast VMODE
......................................................................
Patch Set 8:
(1 comment)
File src/soc/intel/alderlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/66917/comment/8c6def91_81da6300
PS8, Line 261: EnableFastVmode
wondering if this UPD is only exclusive to RPL FSP?
if not, then I do prefer to keep this UPD assignment without any #if guard and guard `fill_vr_fast_vmode()` function call against if (CONFIG(SOC_INTEL_RAPTORLAKE))
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66917
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I313acf01c534d0d32620a9dedba7cf3b304ed2ee
Gerrit-Change-Number: 66917
Gerrit-PatchSet: 8
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Zhixing Ma
zhixing.ma@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Sat, 08 Oct 2022 05:03:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment