Attention is currently required from: Raul Rangel, Jon Murphy, Mark Hasemeyer.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74097 )
Change subject: mb/google/myst: Build for chromeOS
......................................................................
Patch Set 15: Code-Review+2
(1 comment)
File src/mainboard/google/myst/chromeos.c:
https://review.coreboot.org/c/coreboot/+/74097/comment/2bde321c_48852462
PS15, Line 9: void fill_lb_gpios(struct lb_gpios *gpios) {}
Not sure you even need this if this is going to be empty since VBOOT_NO_BOARD_SUPPORT will apply the same -
https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/refs/hea...
Is there somewhere up the CL stack you remove VBOOT_NO_BOARD_SUPPORT config?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74097
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4b6917fe024067409bfbb3d2691c37759b5cace
Gerrit-Change-Number: 74097
Gerrit-PatchSet: 15
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Thu, 06 Apr 2023 16:32:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment