Joel Kitching has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32452
Change subject: vboot: specify NEED_VB20_INTERNALS when needed ......................................................................
vboot: specify NEED_VB20_INTERNALS when needed
NEED_VB20_INTERNALS should always be specified when peeking into vboot internal data structures.
BUG=b:124141368, chromium:956474 TEST=make clean && make test-abuild BRANCH=none
Change-Id: I5a47a28350fd5a68efeff0d06ca150c1ae145412 Signed-off-by: Joel Kitching kitching@google.com --- M src/security/vboot/bootmode.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/32452/1
diff --git a/src/security/vboot/bootmode.c b/src/security/vboot/bootmode.c index 1d6525f..e6e53b6 100644 --- a/src/security/vboot/bootmode.c +++ b/src/security/vboot/bootmode.c @@ -13,6 +13,8 @@ * GNU General Public License for more details. */
+#define NEED_VB20_INTERNALS /* Peeking into vb2_shared_data */ + #include <assert.h> #include <bootmode.h> #include <bootstate.h>
Hello Aaron Durbin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32452
to look at the new patch set (#2).
Change subject: vboot: specify NEED_VB20_INTERNALS when needed ......................................................................
vboot: specify NEED_VB20_INTERNALS when needed
NEED_VB20_INTERNALS should always be specified when peeking into vboot internal data structures.
BUG=b:124141368, chromium:956474 TEST=make clean && make test-abuild BRANCH=none
Change-Id: I5a47a28350fd5a68efeff0d06ca150c1ae145412 Signed-off-by: Joel Kitching kitching@google.com --- M src/security/vboot/bootmode.c M src/security/vboot/vboot_handoff.c 2 files changed, 4 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/32452/2
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32452 )
Change subject: vboot: specify NEED_VB20_INTERNALS when needed ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32452 )
Change subject: vboot: specify NEED_VB20_INTERNALS when needed ......................................................................
vboot: specify NEED_VB20_INTERNALS when needed
NEED_VB20_INTERNALS should always be specified when peeking into vboot internal data structures.
BUG=b:124141368, chromium:956474 TEST=make clean && make test-abuild BRANCH=none
Change-Id: I5a47a28350fd5a68efeff0d06ca150c1ae145412 Signed-off-by: Joel Kitching kitching@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32452 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/security/vboot/bootmode.c M src/security/vboot/vboot_handoff.c 2 files changed, 4 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/src/security/vboot/bootmode.c b/src/security/vboot/bootmode.c index 1d6525f..e6e53b6 100644 --- a/src/security/vboot/bootmode.c +++ b/src/security/vboot/bootmode.c @@ -13,6 +13,8 @@ * GNU General Public License for more details. */
+#define NEED_VB20_INTERNALS /* Peeking into vb2_shared_data */ + #include <assert.h> #include <bootmode.h> #include <bootstate.h> diff --git a/src/security/vboot/vboot_handoff.c b/src/security/vboot/vboot_handoff.c index 047fcaf..ff938e1 100644 --- a/src/security/vboot/vboot_handoff.c +++ b/src/security/vboot/vboot_handoff.c @@ -13,11 +13,8 @@ * GNU General Public License for more details. */
-/* This needs to be pulled in first so that the handoff code below and - * peek into the vb2 data structures. Additionally, vboot doesn't currently - * include what it uses in its own headers. Provide the types it's after. - * TODO: fix this necessity. */ -#define NEED_VB20_INTERNALS +#define NEED_VB20_INTERNALS /* Peeking into vb2_shared_data */ + #include <stddef.h> #include <stdint.h> #include <vb2_api.h>
-
Joel Kitching (Code Review) -
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)