Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33770 )
Change subject: soc/amd/picasso: Update southbridge ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33770/13/src/soc/amd/picasso/includ... File src/soc/amd/picasso/include/soc/southbridge.h:
https://review.coreboot.org/c/coreboot/+/33770/13/src/soc/amd/picasso/includ... PS13, Line 169: #define GPP_CLK_REQ_MAP_CLK6 (1 << GPP_CLK6_REQ_SHL) Mask values are overlapping, is it on purpose? GPP_CLK_REQ_MAP_MASK0 0x0000000f GPP_CLK_REQ_MAP_MASK1 0x0000003c GPP_CLK_REQ_MAP_MASK2 0x000000f0 GPP_CLK_REQ_MAP_MASK3 0x000003c0 GPP_CLK_REQ_MAP_MASK4 0x00000f00 GPP_CLK_REQ_MAP_MASK5 0x00003c00 GPP_CLK_REQ_MAP_MASK6 0x0000f000
https://review.coreboot.org/c/coreboot/+/33770/13/src/soc/amd/picasso/includ... PS13, Line 229: 0x5b This sounds strange, normally it's a pair with STATE being the second register...so it should be 0x61
-
Richard Spiegel (Code Review)