Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37871 )
Change subject: soc/intel/common/block: Enable PMC IPC driver in Coreboot ......................................................................
Patch Set 1:
(9 comments)
https://review.coreboot.org/c/coreboot/+/37871/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37871/1//COMMIT_MSG@7 PS1, Line 7: in Coreboot coreboot is spelled lowerspace. Please remove the part though, as this is the coreboot project.
https://review.coreboot.org/c/coreboot/+/37871/1//COMMIT_MSG@7 PS1, Line 7: Exactly one space please.
https://review.coreboot.org/c/coreboot/+/37871/1/src/soc/intel/common/block/... File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/37871/1/src/soc/intel/common/block/... PS1, Line 42: <0 < 0
https://review.coreboot.org/c/coreboot/+/37871/1/src/soc/intel/common/block/... PS1, Line 42: /* Anything that's not success is <0. Provided solely for readability, as these : * constants are not used outside this file. : */ Please use the allowed comment styles.
https://review.coreboot.org/c/coreboot/+/37871/1/src/soc/intel/common/block/... PS1, Line 45: enum errors { : SUCCESS = 0, : E_TIMEOUT = -1, : E_HW_ERROR = -2, : E_ARGUMENT = -3, : }; Please extend the CB_SUCCESS and friends structure.
https://review.coreboot.org/c/coreboot/+/37871/1/src/soc/intel/common/block/... PS1, Line 624: Please print out the stopwatch time.
https://review.coreboot.org/c/coreboot/+/37871/1/src/soc/intel/common/block/... PS1, Line 627: : int Please use CB_SUCCESS and friends.
https://review.coreboot.org/c/coreboot/+/37871/1/src/soc/intel/common/block/... PS1, Line 640: / Please add spaces around the operator.
https://review.coreboot.org/c/coreboot/+/37871/1/src/soc/intel/common/block/... PS1, Line 658: * Please add spaces.
-
Paul Menzel (Code Review)