Change in coreboot[master]: lockdown: Fix missing spaces in boot log

[Daniel Gröber (dxld) (Code Review)]

Hello Daniel Gröber,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/41748

to review the following change.

Change subject: lockdown: Fix missing spaces in boot log
......................................................................

lockdown: Fix missing spaces in boot log

Change-Id: I414703c53d356c6a69be515596c178997eed82e3
Signed-off-by: Daniel Gröber 
---
M src/security/lockdown/lockdown.c
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/41748/1

diff --git a/src/security/lockdown/lockdown.c b/src/security/lockdown/lockdown.c
index 81478cc..c2e2ac3 100644
--- a/src/security/lockdown/lockdown.c
+++ b/src/security/lockdown/lockdown.c
@@ -28,7 +28,7 @@
    		printk(BIOS_DEBUG, "'WP_RO only'");
    		lock_type = CTRLR_WP;
    	}
-		printk(BIOS_DEBUG, "using CTRL...\n");
+		printk(BIOS_DEBUG, " using CTRL...\n");
    } else {
    	if (CONFIG(BOOTMEDIA_LOCK_WHOLE_RO)) {
    		printk(BIOS_DEBUG, "'readonly'");
@@ -37,7 +37,7 @@
    		printk(BIOS_DEBUG, "'WP_RO only'");
    		lock_type = MEDIA_WP;
    	}
-		printk(BIOS_DEBUG, "using flash chip...\n");
+		printk(BIOS_DEBUG, " using flash chip...\n");
    }

if (CONFIG(BOOTMEDIA_LOCK_WPRO_VBOOT_RO)) {

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41748 )

Change subject: lockdown: Fix missing spaces in boot log
......................................................................

Patch Set 5: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41748 )

Change subject: lockdown: Fix missing spaces in boot log
......................................................................

Patch Set 5: Code-Review+1

Long time no see Danial. Great to have you back.

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41748 )

Change subject: lockdown: Fix missing spaces in boot log
......................................................................

lockdown: Fix missing spaces in boot log

Change-Id: I414703c53d356c6a69be515596c178997eed82e3
Signed-off-by: Daniel Gröber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41748
Reviewed-by: Arthur Heymans 
Reviewed-by: Paul Menzel 
Tested-by: build bot (Jenkins) 
---
M src/security/lockdown/lockdown.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Arthur Heymans: Looks good to me, approved

diff --git a/src/security/lockdown/lockdown.c b/src/security/lockdown/lockdown.c
index 81478cc..c2e2ac3 100644
--- a/src/security/lockdown/lockdown.c
+++ b/src/security/lockdown/lockdown.c
@@ -28,7 +28,7 @@
    		printk(BIOS_DEBUG, "'WP_RO only'");
    		lock_type = CTRLR_WP;
    	}
-		printk(BIOS_DEBUG, "using CTRL...\n");
+		printk(BIOS_DEBUG, " using CTRL...\n");
    } else {
    	if (CONFIG(BOOTMEDIA_LOCK_WHOLE_RO)) {
    		printk(BIOS_DEBUG, "'readonly'");
@@ -37,7 +37,7 @@
    		printk(BIOS_DEBUG, "'WP_RO only'");
    		lock_type = MEDIA_WP;
    	}
-		printk(BIOS_DEBUG, "using flash chip...\n");
+		printk(BIOS_DEBUG, " using flash chip...\n");
    }

if (CONFIG(BOOTMEDIA_LOCK_WPRO_VBOOT_RO)) {

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41748 )

Change subject: lockdown: Fix missing spaces in boot log
......................................................................

Patch Set 6:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4
Emulation targets:
"QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4548
"QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4547
"QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4546
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4545

Please note: This test is under development and might not be accurate at all!