Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.
Jitao Shi has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85951?usp=email )
Change subject: mb/google/rauru: Add panel driver in mainboard
......................................................................
Patch Set 12:
(2 comments)
File src/mainboard/google/rauru/panel_oled.c:
https://review.coreboot.org/c/coreboot/+/85951/comment/325bbdf9_d431b6c1?usp... :
PS11, Line 19: mdelay(400);
I don't think we need this. We take more than 400ms before jumping to payload. […]
Done
https://review.coreboot.org/c/coreboot/+/85951/comment/9bc57328_bce745bc?usp... :
PS11, Line 20: gpio_output(GPIO_AP_EDP_BKLTEN, 1);
: gpio_output(GPIO_BL_PWM_1V8, 1);
We turn on the backlight in the payload. So we should turn off them here.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85951?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iea610c97351beb94a49cc1044701a523b7c85a6e
Gerrit-Change-Number: 85951
Gerrit-PatchSet: 12
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bincai Liu
bincai.liu@mediatek.corp-partner.google.com
Gerrit-CC: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Tue, 21 Jan 2025 03:12:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin
yidilin@google.com