Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Brian Hsu has posted comments on this change by Brian Hsu. ( https://review.coreboot.org/c/coreboot/+/87275?usp=email )
Change subject: mb/google/nissa/var/guren: Add SPD IDs for new memory part
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
Hi all, the memory part was verified by our EE team, please help review if no concern. Thanks a lot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87275?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4616b44a164391d7a14cc97efb059e731d35c308
Gerrit-Change-Number: 87275
Gerrit-PatchSet: 2
Gerrit-Owner: Brian Hsu
brian_hsu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Brian Hsu
brian_hsu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-CC: David Li
david_li@pegatron.corp-partner.google.com
Gerrit-CC: Samuel Chen
samuel_chen@pegatron.corp-partner.google.com
Gerrit-CC: Wayne3 Wang
wayne3_wang@pegatron.corp-partner.google.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 11 Apr 2025 12:18:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes