Edward O'Callaghan (eocallaghan@alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6150
-gerrit
commit 6b17c89c98a39a852c325b30e329e0fc78bafdf7 Author: Edward O'Callaghan eocallaghan@alterapraxis.com Date: Sat Jun 28 18:00:27 2014 +1000
southbridge/dmp/vortex86ex: Incorrect usage of logical vs. bitwise 'or'
Spotted by Clang.
Change-Id: If91f26affb7782348f8ede1d3f0b3badc6cde309 Signed-off-by: Edward O'Callaghan eocallaghan@alterapraxis.com --- src/southbridge/dmp/vortex86ex/southbridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/southbridge/dmp/vortex86ex/southbridge.c b/src/southbridge/dmp/vortex86ex/southbridge.c index b9432f0..c9b10b6 100644 --- a/src/southbridge/dmp/vortex86ex/southbridge.c +++ b/src/southbridge/dmp/vortex86ex/southbridge.c @@ -572,7 +572,7 @@ static void southbridge_init_func1(struct device *dev) pci_write_config32(dev, SB1_REG_EXT_PIRQ_ROUTE2, ext_int_routing2);
/* Assign in-chip PCI device IRQs. */ - if (SPI1_IRQ || MOTOR_IRQ) { + if (SPI1_IRQ | MOTOR_IRQ) { unsigned char irqs[4] = { MOTOR_IRQ, SPI1_IRQ, 0, 0 }; pci_assign_irqs(0, 0x10, irqs); }