Change in coreboot[master]: mb/google/zork: Configure GPIO_89 as PAD_NC

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44190 )

Change subject: mb/google/zork: Configure GPIO_89 as PAD_NC
......................................................................

mb/google/zork: Configure GPIO_89 as PAD_NC

GPIO_89 was marked as EN_DEV_BEEP_L in pre-v3.6 schematics, but it was
never really used on any of the zork variants. Starting with v3.6,
GPIO_89 is left unused in schematics. This change configures GPIO_89
as PAD_NC for all variants since it was never used.

BUG=b:62108046

Change-Id: I026cd6cb598667ce6e115c3ec9357a6a56051d39
Signed-off-by: Furquan Shaikh 
---
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
2 files changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/44190/1

diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
index a07529f..a9ba801 100644
--- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
+++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
@@ -103,8 +103,8 @@
    PAD_NF(GPIO_87, EMMC_DATA7, PULL_NONE),
    /* EMMC_DATA5 */
    PAD_NF(GPIO_88, EMMC_DATA5, PULL_NONE),
-	/*  EN_DEV_BEEP_L */
-	PAD_GPO(GPIO_89, HIGH),
+	/*  GPIO_89 - unused*/
+	PAD_NC(GPIO_89),
    /* RAM ID 1 */
    PAD_GPI(GPIO_90, PULL_NONE),
    /* EN_SPKR */
diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
index c6c728e..978b5aa 100644
--- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
+++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
@@ -109,8 +109,8 @@
    PAD_NF(GPIO_87, EMMC_DATA7, PULL_NONE),
    /* EMMC_DATA5 */
    PAD_NF(GPIO_88, EMMC_DATA5, PULL_NONE),
-	/*  EN_DEV_BEEP_L */
-	PAD_GPO(GPIO_89, HIGH),
+	/*  GPIO_89 - unused */
+	PAD_NC(GPIO_89),
    /* Testpoint */
    PAD_NC(GPIO_90),
    /* EN_SPKR */

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44190 )

Change subject: mb/google/zork: Configure GPIO_89 as PAD_NC
......................................................................

Patch Set 1: Code-Review+2

[Furquan Shaikh (Code Review)]

Hello build bot (Jenkins), Josie Nordrum, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44190

to look at the new patch set (#2).

Change subject: mb/google/zork: Configure GPIO_89 as PAD_NC
......................................................................

mb/google/zork: Configure GPIO_89 as PAD_NC

GPIO_89 was marked as EN_DEV_BEEP_L in pre-v3.6 schematics, but it was
never really used on any of the zork variants. Starting with v3.6,
GPIO_89 is left unused in schematics. This change configures GPIO_89
as PAD_NC for all variants since it was never used.

BUG=b:62108046

Change-Id: I026cd6cb598667ce6e115c3ec9357a6a56051d39
Signed-off-by: Furquan Shaikh 
---
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
2 files changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/44190/2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44190 )

Change subject: mb/google/zork: Configure GPIO_89 as PAD_NC
......................................................................

Patch Set 4: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44190 )

Change subject: mb/google/zork: Configure GPIO_89 as PAD_NC
......................................................................

Patch Set 4:

(3 comments)

https://review.coreboot.org/c/coreboot/+/44190/4/src/mainboard/google/zork/v... 
File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c:

https://review.coreboot.org/c/coreboot/+/44190/4/src/mainboard/google/zork/v... 
PS4, Line 106: */
nit: missing a space here

https://review.coreboot.org/c/coreboot/+/44190/4/src/mainboard/google/zork/v... 
PS4, Line 106:   
nit: double space

https://review.coreboot.org/c/coreboot/+/44190/4/src/mainboard/google/zork/v... 
File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:

https://review.coreboot.org/c/coreboot/+/44190/4/src/mainboard/google/zork/v... 
PS4, Line 112:   
nit: double space

[Furquan Shaikh (Code Review)]

Hello build bot (Jenkins), Angel Pons, Josie Nordrum, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44190

to look at the new patch set (#5).

Change subject: mb/google/zork: Configure GPIO_89 as PAD_NC
......................................................................

mb/google/zork: Configure GPIO_89 as PAD_NC

GPIO_89 was marked as EN_DEV_BEEP_L in pre-v3.6 schematics, but it was
never really used on any of the zork variants. Starting with v3.6,
GPIO_89 is left unused in schematics.

This change configures GPIO_89 as PAD_NC in baseboard GPIO
table. Since EN_DEV_BEEP_L still needs to be driven high to allow
speakers to work, GPIO_89 is configured as PAD_GPO driven high on
pre-v3.6 schematics.

BUG=b:62108046

Change-Id: I026cd6cb598667ce6e115c3ec9357a6a56051d39
Signed-off-by: Furquan Shaikh 
---
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
M src/mainboard/google/zork/variants/berknip/gpio.c
M src/mainboard/google/zork/variants/dalboz/gpio.c
M src/mainboard/google/zork/variants/dirinboz/gpio.c
M src/mainboard/google/zork/variants/ezkinil/gpio.c
M src/mainboard/google/zork/variants/morphius/gpio.c
M src/mainboard/google/zork/variants/trembyle/gpio.c
M src/mainboard/google/zork/variants/vilboz/gpio.c
M src/mainboard/google/zork/variants/woomax/gpio.c
10 files changed, 34 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/44190/5

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44190 )

Change subject: mb/google/zork: Configure GPIO_89 as PAD_NC
......................................................................

Patch Set 5: Code-Review+2

(3 comments)

https://review.coreboot.org/c/coreboot/+/44190/4/src/mainboard/google/zork/v... 
File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c:

https://review.coreboot.org/c/coreboot/+/44190/4/src/mainboard/google/zork/v... 
PS4, Line 106:
> nit: double space

Done

https://review.coreboot.org/c/coreboot/+/44190/4/src/mainboard/google/zork/v... 
PS4, Line 106: */
> nit: missing a space here

Done

https://review.coreboot.org/c/coreboot/+/44190/4/src/mainboard/google/zork/v... 
File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:

https://review.coreboot.org/c/coreboot/+/44190/4/src/mainboard/google/zork/v... 
PS4, Line 112:
> nit: double space

Done

[Furquan Shaikh (Code Review)]

Hello build bot (Jenkins), Angel Pons, Josie Nordrum, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44190

to look at the new patch set (#6).

Change subject: mb/google/zork: Configure GPIO_89 as PAD_NC
......................................................................

mb/google/zork: Configure GPIO_89 as PAD_NC

GPIO_89 was marked as EN_DEV_BEEP_L in pre-v3.6 schematics, but it was
never really used on any of the zork variants. Starting with v3.6,
GPIO_89 is left unused in schematics.

This change configures GPIO_89 as PAD_NC in baseboard GPIO
table. Since EN_DEV_BEEP_L still needs to be driven high to allow
speakers to work, GPIO_89 is configured as PAD_GPO driven high on
pre-v3.6 schematics.

BUG=b:62108046

Change-Id: I026cd6cb598667ce6e115c3ec9357a6a56051d39
Signed-off-by: Furquan Shaikh 
---
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
M src/mainboard/google/zork/variants/berknip/gpio.c
M src/mainboard/google/zork/variants/dalboz/gpio.c
M src/mainboard/google/zork/variants/dirinboz/gpio.c
M src/mainboard/google/zork/variants/ezkinil/gpio.c
M src/mainboard/google/zork/variants/morphius/gpio.c
M src/mainboard/google/zork/variants/trembyle/gpio.c
M src/mainboard/google/zork/variants/vilboz/gpio.c
M src/mainboard/google/zork/variants/woomax/gpio.c
10 files changed, 34 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/44190/6

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44190 )

Change subject: mb/google/zork: Configure GPIO_89 as PAD_NC
......................................................................

Patch Set 6: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44190 )

Change subject: mb/google/zork: Configure GPIO_89 as PAD_NC
......................................................................

mb/google/zork: Configure GPIO_89 as PAD_NC

GPIO_89 was marked as EN_DEV_BEEP_L in pre-v3.6 schematics, but it was
never really used on any of the zork variants. Starting with v3.6,
GPIO_89 is left unused in schematics.

This change configures GPIO_89 as PAD_NC in baseboard GPIO
table. Since EN_DEV_BEEP_L still needs to be driven high to allow
speakers to work, GPIO_89 is configured as PAD_GPO driven high on
pre-v3.6 schematics.

BUG=b:62108046

Change-Id: I026cd6cb598667ce6e115c3ec9357a6a56051d39
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44190
Reviewed-by: Aaron Durbin 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
M src/mainboard/google/zork/variants/berknip/gpio.c
M src/mainboard/google/zork/variants/dalboz/gpio.c
M src/mainboard/google/zork/variants/dirinboz/gpio.c
M src/mainboard/google/zork/variants/ezkinil/gpio.c
M src/mainboard/google/zork/variants/morphius/gpio.c
M src/mainboard/google/zork/variants/trembyle/gpio.c
M src/mainboard/google/zork/variants/vilboz/gpio.c
M src/mainboard/google/zork/variants/woomax/gpio.c
10 files changed, 34 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved

diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
index 4654ff7..e69b47f 100644
--- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
+++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
@@ -103,8 +103,8 @@
    PAD_NF(GPIO_87, EMMC_DATA7, PULL_NONE),
    /* EMMC_DATA5 */
    PAD_NF(GPIO_88, EMMC_DATA5, PULL_NONE),
-	/*  EN_DEV_BEEP_L */
-	PAD_GPO(GPIO_89, HIGH),
+	/* GPIO_89 - unused */
+	PAD_NC(GPIO_89),
    /* RAM ID 1 */
    PAD_GPI(GPIO_90, PULL_NONE),
    /* EN_SPKR */
diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
index 5e61ad8..bf25da3 100644
--- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
+++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
@@ -109,8 +109,8 @@
    PAD_NF(GPIO_87, EMMC_DATA7, PULL_NONE),
    /* EMMC_DATA5 */
    PAD_NF(GPIO_88, EMMC_DATA5, PULL_NONE),
-	/*  EN_DEV_BEEP_L */
-	PAD_GPO(GPIO_89, HIGH),
+	/* GPIO_89 - unused */
+	PAD_NC(GPIO_89),
    /* EN_PWR_TOUCHSCREEN */
    PAD_GPO(GPIO_90, LOW),
    /* EN_SPKR */
diff --git a/src/mainboard/google/zork/variants/berknip/gpio.c b/src/mainboard/google/zork/variants/berknip/gpio.c
index e92bc17..8abe59f 100644
--- a/src/mainboard/google/zork/variants/berknip/gpio.c
+++ b/src/mainboard/google/zork/variants/berknip/gpio.c
@@ -20,6 +20,8 @@
    PAD_GPO(GPIO_67, HIGH),
    /* MST_GPIO_2 (Fw Update HDMI hub) */
    PAD_GPI(GPIO_86, PULL_NONE),
+	/* EN_DEV_BEEP_L */
+	PAD_GPO(GPIO_89, HIGH),
    /* MST_GPIO_3 (Fw Update HDMI hub) */
    PAD_GPI(GPIO_90, PULL_NONE),
    /* USI_RESET */
@@ -27,6 +29,8 @@
 };

static const struct soc_amd_gpio berknip_bid2_gpio_set_stage_ram[] = {
+	/* EN_DEV_BEEP_L */
+	PAD_GPO(GPIO_89, HIGH),
    /* TP */
    PAD_NC(GPIO_90),
    /* USI_RESET */
diff --git a/src/mainboard/google/zork/variants/dalboz/gpio.c b/src/mainboard/google/zork/variants/dalboz/gpio.c
index 20a2fa3..7600d4c 100644
--- a/src/mainboard/google/zork/variants/dalboz/gpio.c
+++ b/src/mainboard/google/zork/variants/dalboz/gpio.c
@@ -17,6 +17,8 @@
    PAD_NC(GPIO_32),
    /* EN_PWR_TOUCHPAD_PS2 */
    PAD_GPO(GPIO_67, HIGH),
+	/* EN_DEV_BEEP_L */
+	PAD_GPO(GPIO_89, HIGH),
    /* USI_RESET */
    PAD_GPO(GPIO_140, HIGH),
    /* Unused */
@@ -30,6 +32,8 @@
    PAD_NC(GPIO_32),
    /* EN_PWR_TOUCHPAD_PS2 */
    PAD_GPO(GPIO_67, HIGH),
+	/* EN_DEV_BEEP_L */
+	PAD_GPO(GPIO_89, HIGH),
    /* USI_RESET */
    PAD_GPO(GPIO_140, HIGH),
 };
diff --git a/src/mainboard/google/zork/variants/dirinboz/gpio.c b/src/mainboard/google/zork/variants/dirinboz/gpio.c
index b79c1d6..12b303a 100644
--- a/src/mainboard/google/zork/variants/dirinboz/gpio.c
+++ b/src/mainboard/google/zork/variants/dirinboz/gpio.c
@@ -10,6 +10,8 @@
 static const struct soc_amd_gpio bid_1_gpio_set_stage_ram[] = {
    /* TP */
    PAD_NC(GPIO_32),
+	/* EN_DEV_BEEP_L */
+	PAD_GPO(GPIO_89, HIGH),
    /* USI_RESET */
    PAD_GPO(GPIO_140, HIGH),
 };
diff --git a/src/mainboard/google/zork/variants/ezkinil/gpio.c b/src/mainboard/google/zork/variants/ezkinil/gpio.c
index 1bbc301..f8664bb 100644
--- a/src/mainboard/google/zork/variants/ezkinil/gpio.c
+++ b/src/mainboard/google/zork/variants/ezkinil/gpio.c
@@ -20,6 +20,8 @@
    PAD_GPO(GPIO_67, HIGH),
    /* MST_GPIO_2 (Fw Update HDMI hub) */
    PAD_GPI(GPIO_86, PULL_NONE),
+	/* EN_DEV_BEEP_L */
+	PAD_GPO(GPIO_89, HIGH),
    /* MST_GPIO_3 (Fw Update HDMI hub) */
    PAD_GPI(GPIO_90, PULL_NONE),
    /* USI_RESET */
@@ -39,6 +41,8 @@
    PAD_NC(GPIO_69),
    /* MST_GPIO_2 (Fw Update HDMI hub) Change NC */
    PAD_NC(GPIO_86),
+	/* EN_DEV_BEEP_L */
+	PAD_GPO(GPIO_89, HIGH),
    /* TP */
    PAD_NC(GPIO_90),
    /* USI_RESET */
@@ -50,6 +54,8 @@
    PAD_NC(GPIO_11),
    /* FPMCU_BOOT0 Change NC */
    PAD_NC(GPIO_69),
+	/* EN_DEV_BEEP_L */
+	PAD_GPO(GPIO_89, HIGH),
    /* TP */
    PAD_NC(GPIO_90),
    /* USI_RESET */
diff --git a/src/mainboard/google/zork/variants/morphius/gpio.c b/src/mainboard/google/zork/variants/morphius/gpio.c
index 8376e8c..8da0de4 100644
--- a/src/mainboard/google/zork/variants/morphius/gpio.c
+++ b/src/mainboard/google/zork/variants/morphius/gpio.c
@@ -22,6 +22,8 @@
    PAD_GPO(GPIO_84, HIGH),
    /* MST_GPIO_2 (Fw Update HDMI hub) */
    PAD_GPI(GPIO_86, PULL_NONE),
+	/* EN_DEV_BEEP_L */
+	PAD_GPO(GPIO_89, HIGH),
    /* MST_GPIO_3 (Fw Update HDMI hub) */
    PAD_GPI(GPIO_90, PULL_NONE),
    /* USI_RESET */
@@ -41,6 +43,8 @@
    PAD_GPO(GPIO_67, HIGH),
    /* MST_GPIO_2 (Fw Update HDMI hub) */
    PAD_GPI(GPIO_86, PULL_NONE),
+	/* EN_DEV_BEEP_L */
+	PAD_GPO(GPIO_89, HIGH),
    /* MST_GPIO_3 (Fw Update HDMI hub) */
    PAD_GPI(GPIO_90, PULL_NONE),
    /* USI_RESET */
@@ -48,6 +52,8 @@
 };

static const struct soc_amd_gpio morphius_bid3_gpio_set_stage_ram[] = {
+	/* EN_DEV_BEEP_L */
+	PAD_GPO(GPIO_89, HIGH),
    /* TP */
    PAD_NC(GPIO_90),
    /* USI_RESET */
diff --git a/src/mainboard/google/zork/variants/trembyle/gpio.c b/src/mainboard/google/zork/variants/trembyle/gpio.c
index fc0d2c6..9931479 100644
--- a/src/mainboard/google/zork/variants/trembyle/gpio.c
+++ b/src/mainboard/google/zork/variants/trembyle/gpio.c
@@ -22,6 +22,8 @@
    PAD_GPO(GPIO_84, HIGH),
    /* MST_GPIO_2 (Fw Update HDMI hub) */
    PAD_GPI(GPIO_86, PULL_NONE),
+	/* EN_DEV_BEEP_L */
+	PAD_GPO(GPIO_89, HIGH),
    /* MST_GPIO_3 (Fw Update HDMI hub) */
    PAD_GPI(GPIO_90, PULL_NONE),
    /* USI_RESET */
@@ -41,6 +43,8 @@
    PAD_GPO(GPIO_67, HIGH),
    /* MST_GPIO_2 (Fw Update HDMI hub) */
    PAD_GPI(GPIO_86, PULL_NONE),
+	/* EN_DEV_BEEP_L */
+	PAD_GPO(GPIO_89, HIGH),
    /* MST_GPIO_3 (Fw Update HDMI hub) */
    PAD_GPI(GPIO_90, PULL_NONE),
    /* USI_RESET */
diff --git a/src/mainboard/google/zork/variants/vilboz/gpio.c b/src/mainboard/google/zork/variants/vilboz/gpio.c
index b79c1d6..12b303a 100644
--- a/src/mainboard/google/zork/variants/vilboz/gpio.c
+++ b/src/mainboard/google/zork/variants/vilboz/gpio.c
@@ -10,6 +10,8 @@
 static const struct soc_amd_gpio bid_1_gpio_set_stage_ram[] = {
    /* TP */
    PAD_NC(GPIO_32),
+	/* EN_DEV_BEEP_L */
+	PAD_GPO(GPIO_89, HIGH),
    /* USI_RESET */
    PAD_GPO(GPIO_140, HIGH),
 };
diff --git a/src/mainboard/google/zork/variants/woomax/gpio.c b/src/mainboard/google/zork/variants/woomax/gpio.c
index d493882..968c622 100644
--- a/src/mainboard/google/zork/variants/woomax/gpio.c
+++ b/src/mainboard/google/zork/variants/woomax/gpio.c
@@ -18,6 +18,8 @@
    PAD_NC(GPIO_69),
    /* RAM_ID_4  */
    PAD_NC(GPIO_84),
+	/* EN_DEV_BEEP_L */
+	PAD_GPO(GPIO_89, HIGH),
    /* TP */
    PAD_NC(GPIO_90),
    /* USI_RESET */