Attention is currently required from: Felix Singer, Hung-Te Lin, Julius Werner, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79063?usp=email )
Change subject: google/*: Clean up Kconfg board selection for Google MTK boards
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
File src/mainboard/google/corsola/Kconfig:
https://review.coreboot.org/c/coreboot/+/79063/comment/df56a761_7b31c3b8 :
PS1, Line 22: select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_CHINCHOU
I hope I can still assume that at least Staryu is the variant for all the MIPI boards, though?
Yes we can.
I think it would be best to just have an explicit list for each instead. I wrote it that way now, let me know what you think.
Agreed. PS2 looks good to me.
File src/mainboard/google/geralt/Kconfig:
https://review.coreboot.org/c/coreboot/+/79063/comment/51494960_aea1c083 :
PS2, Line 74: choice
I removed the `choice` here because a choice always needs to have a prompt, and these kinds of hardw […]
Fine by me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79063?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I40880e7609ba703d0053ad01da742871e54d4e7a
Gerrit-Change-Number: 79063
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Tue, 21 Nov 2023 02:21:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment