Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43823 )
Change subject: Makefile: Remove ltinfo ......................................................................
Makefile: Remove ltinfo
Change-Id: Ie753332088be360d38dae97dfe34c24af12078fc Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M util/kconfig/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/43823/1
diff --git a/util/kconfig/Makefile b/util/kconfig/Makefile index 1713b8d..c9aa63e 100644 --- a/util/kconfig/Makefile +++ b/util/kconfig/Makefile @@ -126,7 +126,7 @@ HOST_EXTRACFLAGS += $(shell $(CONFIG_SHELL) $(check-lxdialog) -ccflags) \ -DLOCALE HOST_LOADLIBES = $(shell $(CONFIG_SHELL) $(check-lxdialog) \ - -ldflags $(HOSTCC)) -ltinfo + -ldflags $(HOSTCC))
# ===========================================================================
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43823 )
Change subject: Makefile: Remove ltinfo ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43823/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43823/2//COMMIT_MSG@7 PS2, Line 7: Makefile: Remove ltinfo What for? I'm curious.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43823
to look at the new patch set (#4).
Change subject: kconfig/Makefile: Remove `-ltinfo` from host library list ......................................................................
kconfig/Makefile: Remove `-ltinfo` from host library list
This reverts commit 622a28d22b917dec29d8b75aab8cdf55300a7e4c.
util/kconfig: Fix missing library issue with ld 2.24 and newer
`libtinfo.so` is not available on all installations.
$ make menuconfig /usr/lib/gcc/x86_64-pc-linux-gnu/7.5.0/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -ltinfo collect2: error: ld returned 1 exit status
The upstream Kconfig build system in the Linux kernel also does have this, so remove it from `HOST_LOADLIBES`.
Change-Id: Ie753332088be360d38dae97dfe34c24af12078fc Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M util/kconfig/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/43823/4
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43823 )
Change subject: kconfig/Makefile: Remove `-ltinfo` from host library list ......................................................................
Patch Set 5: Code-Review+1
Maybe mention that workarounds for old compilers don't really make sense? You can refer to CB:43143
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43823?usp=email )
Change subject: kconfig/Makefile: Remove `-ltinfo` from host library list ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-
Angel Pons (Code Review) -
Martin L Roth (Code Review)
-
Paul Menzel (Code Review)