[M] Change in coreboot[main]: soc/intel/common/block: Add support for watchdog

[Marek Maślanka (Code Review)]

Attention is currently required from: Jakub Czapiga, Michał Żygowski, Subrata Banik.

Marek Maślanka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79909?usp=email )

Change subject: soc/intel/common/block: Add support for watchdog
......................................................................

Patch Set 15:

(5 comments)

File src/soc/intel/common/block/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/79909/comment/a8c4c59c_803389e1 :
PS13, Line 396: rightmost_bit_offset
> > The only thing that comes to mind to make the name more descriptive is to change it to `find_right […]

thanks, the `__builtin_ctzll` is doing what I needed.

File src/soc/intel/common/block/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/79909/comment/a6e5abe4_4be5071f :
PS14, Line 408: tcobase
> are we okay to go forward if tcobase is not even programmed ? like zero ?

`tcobase != 0` is already checked earlier in the caller function

https://review.coreboot.org/c/coreboot/+/79909/comment/585cda93_c59fbecb :
PS14, Line 430: 0x01
> can we have a macro ?

Done

https://review.coreboot.org/c/coreboot/+/79909/comment/241866f3_4713bafc :
PS14, Line 469: acpi_soc_fill_wdat
> do u have a caller of this function implemented already ?

yes, it's called from acpi_create_wdat (src/acpi/acpi.c) if CONFIG_ACPI_WDAT_WDT is enabled

https://review.coreboot.org/c/coreboot/+/79909/comment/fbb6ddf8_61d0fc8a :
PS14, Line 487: 	if (tcobase == 0) {
              : 		wdat->flags = ACPI_WDAT_FLAG_DISABLED;
              : 		return current;
              : 	}
> shouldn't we return this at line 474?

right, just filling the flags to ACPI_WDAT_FLAG_DISABLED is enough