Attention is currently required from: Arthur Heymans, Chen, Gang C, Christian Walter, David Hendricks, Jincheng Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Shuo Liu, TangYiwei, Tim Chu.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81316?usp=email )
Change subject: soc/intel/xeon_sp: Add GraniteRapids initial codes ......................................................................
Patch Set 5:
(9 comments)
File src/soc/intel/xeon_sp/chip_fsp24.c:
https://review.coreboot.org/c/coreboot/+/81316/comment/b14bd1af_0d12b09b : PS5, Line 92: map_uid_to_domain_type Not needed when the caller passes the correct domain type.
https://review.coreboot.org/c/coreboot/+/81316/comment/dfdcea6a_879fc19e : PS5, Line 95: root Not needed when PCI root bridges on the same stack do not use overlapping bus ranges.
https://review.coreboot.org/c/coreboot/+/81316/comment/49a1742f_94074c96 : PS5, Line 118: soc_create_fsp24_domains This is wrong. You also know that it's an ubox domain, no need to figure it out again in soc_create_fsp24_domains.
File src/soc/intel/xeon_sp/gnr/soc_acpi.c:
https://review.coreboot.org/c/coreboot/+/81316/comment/5ef8f916_f8a2f27a : PS5, Line 3: acpigen do you need all those headers?
https://review.coreboot.org/c/coreboot/+/81316/comment/8afd97cc_6ba307a5 : PS5, Line 57: uncore_fill_ssdt removed from main branch
File src/soc/intel/xeon_sp/gnr/soc_util.c:
https://review.coreboot.org/c/coreboot/+/81316/comment/456cc9a0_2a445724 : PS5, Line 127: sizeof ARRAY_SIZE
File src/soc/intel/xeon_sp/uncore.c:
https://review.coreboot.org/c/coreboot/+/81316/comment/0da964fc_187c16db : PS5, Line 306: ) soc specific code should be moved out of common code
File src/soc/intel/xeon_sp/uncore_acpi.c:
https://review.coreboot.org/c/coreboot/+/81316/comment/923daca7_5b0e9f09 : PS5, Line 25: MemoryMapDataHob unrelated?
File src/soc/intel/xeon_sp/util.c:
https://review.coreboot.org/c/coreboot/+/81316/comment/a839869e_7a2d3bc0 : PS5, Line 24: unlock_pam_regions Is it needed at all? I could not figure out what it does or why.