Change in coreboot[4.11_branch]: smbios: Add option VPD_SMBIOS_VERSION that reads BIOS version from a ...

[Christian Walter (Code Review)]

Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42747 )

Change subject: smbios: Add option VPD_SMBIOS_VERSION that reads BIOS version from a VPD variable
......................................................................

Patch Set 2:

(4 comments)

https://review.coreboot.org/c/coreboot/+/42747/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42747/2//COMMIT_MSG@7 
PS2, Line 7: smbios: Add option VPD_SMBIOS_VERSION that reads BIOS version from a VPD variable
line is too long

https://review.coreboot.org/c/coreboot/+/42747/2//COMMIT_MSG@9 
PS2, Line 9: If 
same goes for the complete message

https://review.coreboot.org/c/coreboot/+/42747/2/src/arch/x86/smbios.c 
File src/arch/x86/smbios.c:

https://review.coreboot.org/c/coreboot/+/42747/2/src/arch/x86/smbios.c@386 
PS2, Line 386: #
IMHO define should be in a header or at the top of the file

https://review.coreboot.org/c/coreboot/+/42747/2/src/arch/x86/smbios.c@414 
PS2, Line 414: #
same goes for this