Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35268 )
Change subject: soc/amd/common: Add missing stdint.h to acpummio.h ......................................................................
soc/amd/common: Add missing stdint.h to acpummio.h
Change-Id: I3eae80a677e9d6932dc115523da2c0819a371fa7 Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/common/block/include/amdblocks/acpimmio.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/35268/1
diff --git a/src/soc/amd/common/block/include/amdblocks/acpimmio.h b/src/soc/amd/common/block/include/amdblocks/acpimmio.h index 32da867..59ab9e5 100644 --- a/src/soc/amd/common/block/include/amdblocks/acpimmio.h +++ b/src/soc/amd/common/block/include/amdblocks/acpimmio.h @@ -18,6 +18,7 @@ #ifndef __AMDBLOCKS_ACPIMMIO_H__ #define __AMDBLOCKS_ACPIMMIO_H__
+#include <stdint.h> /* iomap.h must indicate if the device uses a block, optional if unused. */ #include <soc/iomap.h> #ifndef SUPPORTS_ACPIMMIO_SMI_BASE
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35268 )
Change subject: soc/amd/common: Add missing stdint.h to acpummio.h ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35268/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35268/1//COMMIT_MSG@8 PS1, Line 8: Pleasedeclare why it's needed.
Hello Richard Spiegel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35268
to look at the new patch set (#2).
Change subject: soc/amd/common: Add missing stdint.h to acpummio.h ......................................................................
soc/amd/common: Add missing stdint.h to acpummio.h
Include the file containing the typedefs for uint_*.
Change-Id: I3eae80a677e9d6932dc115523da2c0819a371fa7 Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/common/block/include/amdblocks/acpimmio.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/35268/2
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35268 )
Change subject: soc/amd/common: Add missing stdint.h to acpummio.h ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35268/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35268/1//COMMIT_MSG@8 PS1, Line 8:
Pleasedeclare why it's needed.
Done
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35268 )
Change subject: soc/amd/common: Add missing stdint.h to acpummio.h ......................................................................
Patch Set 2: Code-Review+2
Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35268 )
Change subject: soc/amd/common: Add missing stdint.h to acpummio.h ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35268/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35268/2//COMMIT_MSG@7 PS2, Line 7: acpummio.h acpimmio.h
Hello Richard Spiegel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35268
to look at the new patch set (#3).
Change subject: soc/amd/common: Add missing stdint.h to acpimmio.h ......................................................................
soc/amd/common: Add missing stdint.h to acpimmio.h
Include the file containing the typedefs for uint_*.
Change-Id: I3eae80a677e9d6932dc115523da2c0819a371fa7 Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/common/block/include/amdblocks/acpimmio.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/35268/3
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35268 )
Change subject: soc/amd/common: Add missing stdint.h to acpimmio.h ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35268/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35268/2//COMMIT_MSG@7 PS2, Line 7: acpummio.h
acpimmio. […]
thanks
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35268 )
Change subject: soc/amd/common: Add missing stdint.h to acpimmio.h ......................................................................
soc/amd/common: Add missing stdint.h to acpimmio.h
Include the file containing the typedefs for uint_*.
Change-Id: I3eae80a677e9d6932dc115523da2c0819a371fa7 Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35268 Reviewed-by: Richard Spiegel richard.spiegel@silverbackltd.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/common/block/include/amdblocks/acpimmio.h 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Richard Spiegel: Looks good to me, approved
diff --git a/src/soc/amd/common/block/include/amdblocks/acpimmio.h b/src/soc/amd/common/block/include/amdblocks/acpimmio.h index 32da867..59ab9e5 100644 --- a/src/soc/amd/common/block/include/amdblocks/acpimmio.h +++ b/src/soc/amd/common/block/include/amdblocks/acpimmio.h @@ -18,6 +18,7 @@ #ifndef __AMDBLOCKS_ACPIMMIO_H__ #define __AMDBLOCKS_ACPIMMIO_H__
+#include <stdint.h> /* iomap.h must indicate if the device uses a block, optional if unused. */ #include <soc/iomap.h> #ifndef SUPPORTS_ACPIMMIO_SMI_BASE
-
Felix Held (Code Review) -
Marshall Dawson (Code Review)
-
Name of user not set (Code Review)
-
Richard Spiegel (Code Review)