Attention is currently required from: Raul Rangel, Jason Nien, EricKY Cheng, Isaac Lee, Jon Murphy, Tim Wawrzynczak, Martin Roth, Eric Peers, Moises Garcia, Karthikeyan Ramasubramanian.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68077 )
Change subject: mb/google/skyrim/var/winterhold: Expend EC share memory register define for Dynamic Thermal Table Switching Proposal
......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68077/comment/b4d33a8f_4a0ff24e
PS2, Line 7: mb/google/skyrim/var/winterhold: Expend EC share memory
: register define for Dynamic Thermal Table Switching Proposal
ec/google/chromeec/acpi/ec: Add STTT, STTB
https://review.coreboot.org/c/coreboot/+/68077/comment/b059d3d4_939f6661
PS2, Line 10: Define offset 0x09 bit 5 for temperature status of thermal
: table switch
nit: Add "STTT", to clarify which this is.
https://review.coreboot.org/c/coreboot/+/68077/comment/6bf013c8_03289599
PS2, Line 12: Define offset 0x09 bit 6 for body detection status of thermal
: table switch
Same. Add "STTB".
File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/68077/comment/f061b7db_9906226e
PS2, Line 59: RSV1, 1, // Reserved bit
Why is 1 bit being reserved? Why can't these be bits 4 and 5?
https://review.coreboot.org/c/coreboot/+/68077/comment/315ab149_a5c57cc4
PS2, Line 61:
whitespace: use tab here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68077
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37b3a0d8f6546361c8d5501e98e3e1b0d814fce3
Gerrit-Change-Number: 68077
Gerrit-PatchSet: 2
Gerrit-Owner: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Isaac Lee
isaaclee@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Moises Garcia
moisesgarcia@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Attention: Isaac Lee
isaaclee@google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Attention: Moises Garcia
moisesgarcia@google.com
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Comment-Date: Mon, 03 Oct 2022 15:49:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment