Attention is currently required from: Paul Menzel, Zheng Bao.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66855 )
Change subject: amdfwtool: Seperate two cases of combo and non-combo clearly
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/66855/comment/53a1b8aa_e901e007
PS4, Line 7: combo:
Is it needed as it’s mention in the summary.
Done
https://review.coreboot.org/c/coreboot/+/66855/comment/9dd10d1e_90785c35
PS4, Line 8:
Please elaborate.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66855
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0057165aea553d9dc8e4e719e2804557229a0002
Gerrit-Change-Number: 66855
Gerrit-PatchSet: 5
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Mon, 05 Sep 2022 03:21:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment