Attention is currently required from: Tarun Tuli, Subrata Banik, Ravishankar Sarawadi, Kapil Porwal, Paul Menzel, Uday Bhat, Anil Kumar K, Jairaj Arava.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72881 )
Change subject: mb/google/rex: Enable audio BT offload
......................................................................
Patch Set 15:
(1 comment)
File src/mainboard/google/rex/variants/rex0/fw_config.c:
https://review.coreboot.org/c/coreboot/+/72881/comment/ed8e9e16_788a68cb
PS15, Line 77: if (!fw_config_is_provisioned()) {
We can combine this into FW config probe. fw_config_probe will return false if provisioned, so you don't have to probe AUDIO_UNKNOWN as well. So we can do
if (fw_config_probe(FW_CONFIG(AUDIO, MAX98363_CS42L42_SNDW))
else if (fw_config_probe(FW_CONFIG(AUDIO, MAX98360_ALC5682I_I2S))
else {
disable all
}
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72881
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46e9702add37464122ffc78826ebf8a6c5b5b07c
Gerrit-Change-Number: 72881
Gerrit-PatchSet: 15
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Harsha B R
harsha.b.r@intel.com
Gerrit-Reviewer: Jairaj Arava
jairaj.arava@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Uday Bhat
uday.m.bhat@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-CC: Uday M Bhat
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Uday Bhat
uday.m.bhat@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-Attention: Jairaj Arava
jairaj.arava@intel.com
Gerrit-Comment-Date: Thu, 06 Apr 2023 05:46:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment