Change in coreboot[master]: coreinfo/coreinfo.c: Provide information of time format

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Name of user not set (Code Review)

7 Oct 2019 7 Oct '19

11:56 a.m.

Name of user not set #1002476 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35847 )

Change subject: coreinfo/coreinfo.c: Provide information of time format ......................................................................

coreinfo/coreinfo.c: Provide information of time format

Specify Coordinated Universal Time (UTC) time format while print date and time in the coreinfo payload.

Change-Id: I359cef7697daf5d92d2c9fb58bf75c5b1345e982 Signed-off-by: Sourabh Kashyap sourabhka@hcl.com --- M payloads/coreinfo/coreinfo.c 1 file changed, 4 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/35847/1

diff --git a/payloads/coreinfo/coreinfo.c b/payloads/coreinfo/coreinfo.c index 53985b2..ea4d424 100644 --- a/payloads/coreinfo/coreinfo.c +++ b/payloads/coreinfo/coreinfo.c @@ -124,8 +124,10 @@

rtc_read_clock(&tm);

- mvwprintw(menuwin, 1, 57, "%02d/%02d/%04d - %02d:%02d:%02d", - tm.tm_mon + 1, tm.tm_mday, 1900 + tm.tm_year, tm.tm_hour, + mvwprintw(menuwin, 1, 53, "%02d/%02d/%04d", tm.tm_mon + 1, + tm.tm_mday, 1900 + tm.tm_year); + mvwprintw(menuwin, 1, 63, " - UTC "); + mvwprintw(menuwin, 1, 70, "%02d:%02d:%02d", tm.tm_hour, tm.tm_min, tm.tm_sec); } #endif

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Paul Menzel (Code Review)

10 Oct 10 Oct

12:53 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35847 )

Change subject: coreinfo/coreinfo.c: Provide information of time format ......................................................................

Patch Set 1: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/35847/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35847/1//COMMIT_MSG@9 PS1, Line 9: while print for printing?

https://review.coreboot.org/c/coreboot/+/35847/1//COMMIT_MSG@9 PS1, Line 9: print printing

-- To view, visit https://review.coreboot.org/c/coreboot/+/35847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I359cef7697daf5d92d2c9fb58bf75c5b1345e982 Gerrit-Change-Number: 35847 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 10 Oct 2019 10:53:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Name of user not set (Code Review)

5:10 p.m.

Hello Angel Pons, Paul Menzel, build bot (Jenkins), Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35847

to look at the new patch set (#2).

Change subject: coreinfo/coreinfo.c: Provide information of time format ......................................................................

coreinfo/coreinfo.c: Provide information of time format

Specify Coordinated Universal Time (UTC) time format while printing date and time in the coreinfo payload.

Change-Id: I359cef7697daf5d92d2c9fb58bf75c5b1345e982 Signed-off-by: Sourabh Kashyap sourabhka@hcl.com --- M payloads/coreinfo/coreinfo.c 1 file changed, 4 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/35847/2

Name of user not set (Code Review)

5:11 p.m.

Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35847 )

Change subject: coreinfo/coreinfo.c: Provide information of time format ......................................................................

Patch Set 2:

(2 comments)

Done

https://review.coreboot.org/c/coreboot/+/35847/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35847/1//COMMIT_MSG@9 PS1, Line 9: print

...

printing

Ack

https://review.coreboot.org/c/coreboot/+/35847/1//COMMIT_MSG@9 PS1, Line 9: while print

...

for printing?

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/35847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I359cef7697daf5d92d2c9fb58bf75c5b1345e982 Gerrit-Change-Number: 35847 Gerrit-PatchSet: 2 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 10 Oct 2019 15:11:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Patrick Georgi (Code Review)

1 Nov 1 Nov

1:13 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35847 )

Change subject: coreinfo/coreinfo.c: Provide information of time format ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35847/2/payloads/coreinfo/coreinfo.... File payloads/coreinfo/coreinfo.c:

https://review.coreboot.org/c/coreboot/+/35847/2/payloads/coreinfo/coreinfo.... PS2, Line 127: - Why do you split it into three calls? Can't you just add " UTC" in here and adapt the x offset?

-- To view, visit https://review.coreboot.org/c/coreboot/+/35847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I359cef7697daf5d92d2c9fb58bf75c5b1345e982 Gerrit-Change-Number: 35847 Gerrit-PatchSet: 2 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 01 Nov 2019 12:13:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Name of user not set (Code Review)

10 Dec 10 Dec

9:23 a.m.

Hello HAOUAS Elyes, Angel Pons, Stefan Reinauer, Paul Menzel, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35847

to look at the new patch set (#3).

Change subject: coreinfo/coreinfo.c: Provide information of time format ......................................................................

coreinfo/coreinfo.c: Provide information of time format

Specify Coordinated Universal Time (UTC) time format while printing date and time in the coreinfo payload.

Change-Id: I359cef7697daf5d92d2c9fb58bf75c5b1345e982 Signed-off-by: Himanshu Sahdev himanshusah@hcl.com --- M payloads/coreinfo/coreinfo.c 1 file changed, 4 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/35847/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/35847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I359cef7697daf5d92d2c9fb58bf75c5b1345e982 Gerrit-Change-Number: 35847 Gerrit-PatchSet: 3 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Name of user not set (Code Review)

9:26 a.m.

Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35847 )

Change subject: coreinfo/coreinfo.c: Provide information of time format ......................................................................

Patch Set 3:

(1 comment)

Done!

https://review.coreboot.org/c/coreboot/+/35847/2/payloads/coreinfo/coreinfo.... File payloads/coreinfo/coreinfo.c:

https://review.coreboot.org/c/coreboot/+/35847/2/payloads/coreinfo/coreinfo.... PS2, Line 127: -

...

Why do you split it into three calls? Can't you just add " UTC" in here and adapt the x offset?

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/35847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I359cef7697daf5d92d2c9fb58bf75c5b1345e982 Gerrit-Change-Number: 35847 Gerrit-PatchSet: 3 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 10 Dec 2019 08:26:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Name of user not set (Code Review)

9:30 a.m.

Hello HAOUAS Elyes, Angel Pons, Stefan Reinauer, Paul Menzel, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35847

to look at the new patch set (#4).

Change subject: coreinfo/coreinfo.c: Provide information of time format ......................................................................

coreinfo/coreinfo.c: Provide information of time format

Specify Coordinated Universal Time (UTC) time format while printing date and time in the coreinfo payload.

Change-Id: I359cef7697daf5d92d2c9fb58bf75c5b1345e982 Signed-off-by: Sourabh Kashyap sourabhka@hcl.com --- M payloads/coreinfo/coreinfo.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/35847/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/35847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I359cef7697daf5d92d2c9fb58bf75c5b1345e982 Gerrit-Change-Number: 35847 Gerrit-PatchSet: 4 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Name of user not set (Code Review)

9:31 a.m.

Hello HAOUAS Elyes, Angel Pons, Stefan Reinauer, Paul Menzel, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35847

to look at the new patch set (#5).

Change subject: coreinfo/coreinfo.c: Provide information of time format ......................................................................

coreinfo/coreinfo.c: Provide information of time format

Specify Coordinated Universal Time (UTC) time format while printing date and time in the coreinfo payload.

Change-Id: I359cef7697daf5d92d2c9fb58bf75c5b1345e982 Signed-off-by: Himanshu Sahdev himanshusah@hcl.com --- M payloads/coreinfo/coreinfo.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/35847/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/35847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I359cef7697daf5d92d2c9fb58bf75c5b1345e982 Gerrit-Change-Number: 35847 Gerrit-PatchSet: 5 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Paul Menzel (Code Review)

11:15 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35847 )

Change subject: coreinfo/coreinfo.c: Provide information of time format ......................................................................

Patch Set 5: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/35847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I359cef7697daf5d92d2c9fb58bf75c5b1345e982 Gerrit-Change-Number: 35847 Gerrit-PatchSet: 5 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 10 Dec 2019 10:15:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin L Roth (Code Review)

7 Aug 7 Aug

10:45 p.m.

New subject: [XS] Change in coreboot[master]: coreinfo/coreinfo.c: Provide information of time format

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/35847?usp=email )

Change subject: coreinfo/coreinfo.c: Provide information of time format ......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35847?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I359cef7697daf5d92d2c9fb58bf75c5b1345e982 Gerrit-Change-Number: 35847 Gerrit-PatchSet: 5 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin L Roth gaumless@gmail.com Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: abandon

473

days inactive

1873

days old

coreboot-gerrit@coreboot.org

10 comments

4 participants

tags (0)

participants (4)

Martin L Roth (Code Review)
Name of user not set (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)