Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35847 ) Change subject: coreinfo/coreinfo.c: Provide information of time format ...................................................................... Patch Set 3: (1 comment) Done! https://review.coreboot.org/c/coreboot/+/35847/2/payloads/coreinfo/coreinfo.... File payloads/coreinfo/coreinfo.c: https://review.coreboot.org/c/coreboot/+/35847/2/payloads/coreinfo/coreinfo.... PS2, Line 127: -
Why do you split it into three calls? Can't you just add " UTC" in here and adapt the x offset? Ack
-- To view, visit https://review.coreboot.org/c/coreboot/+/35847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I359cef7697daf5d92d2c9fb58bf75c5b1345e982 Gerrit-Change-Number: 35847 Gerrit-PatchSet: 3 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 10 Dec 2019 08:26:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <pgeorgi@google.com> Gerrit-MessageType: comment