Attention is currently required from: Kyösti Mälkki.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55069 )
Change subject: lib/bootmem.c: Use only e820 compatible types
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
This changes linuxbios table entries, not just what results in e820. Eg. util/cbmem needs to see LB_MEM_TABLE present.
Ah I see. So util/cbmem could be fixed by looking at LB_TAG_CBMEM_ENTRY instead of LB_TAG_MEMORY entries. IDK however if other payloads rely on that API but it looks like it is currently causing more problems than anything else if both FILO and GRUB fix this up (and SeaBIOS already doing that).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55069
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4797ac9dca1a8f43f104654d0e113236205a288a
Gerrit-Change-Number: 55069
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sat, 29 May 2021 14:35:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment