Change in coreboot[master]: binaryPI: Drop CAR teardown without POSTCAR_STAGE - coreboot-gerrit

24 Nov 2019


      Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18526 )
Change subject: binaryPI: Drop CAR teardown without POSTCAR_STAGE
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/18526/8/src/vendorcode/amd/pi/00630... 
File src/vendorcode/amd/pi/00630F01/binaryPI/gcccar.inc:
https://review.coreboot.org/c/coreboot/+/18526/8/src/vendorcode/amd/pi/00630... 
PS8, Line 920: wbinvd
Was this used as a very hacky way to make sure cbmem hits ram during romstage? That is definitely nasty and makes me wonder if S3 resume is even possible doing this.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/18526
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I693c104c3aab3be537c00695cbd764a48bd603b0
Gerrit-Change-Number: 18526
Gerrit-PatchSet: 8
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Marc Jones marc@marcjonesconsulting.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 24 Nov 2019 17:27:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment