Change in ...coreboot[master]: soc/intel/braswell/acpi/globalnvs.asl: Remove redundant use of Offset
Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32953
Change subject: soc/intel/braswell/acpi/globalnvs.asl: Remove redundant use of Offset ......................................................................
soc/intel/braswell/acpi/globalnvs.asl: Remove redundant use of Offset
ASL compiler reports twice warning 'unnecessary/redundant use of Offfset operator'.
Remove redundant offsets.
BUG=N/A TEST=Facebook FBG-1701 booting Embedded Linux
Change-Id: I16705b9392b17c50d3988012406e03de393cbcd2 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/soc/intel/braswell/acpi/globalnvs.asl 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/32953/1
diff --git a/src/soc/intel/braswell/acpi/globalnvs.asl b/src/soc/intel/braswell/acpi/globalnvs.asl index c0b0b8d..9bd9afc 100644 --- a/src/soc/intel/braswell/acpi/globalnvs.asl +++ b/src/soc/intel/braswell/acpi/globalnvs.asl @@ -31,7 +31,6 @@ Field (GNVS, ByteAcc, NoLock, Preserve) { /* Miscellaneous */ - Offset (0x00), OSYS, 16, /* 0x00 - Operating System */ SMIF, 8, /* 0x02 - SMI function */ PRM0, 8, /* 0x03 - SMI function parameter */ @@ -55,7 +54,6 @@ CID1, 16, /* 0x1e - Wifi Domain Type */
/* Device Config */ - Offset (0x20), S5U0, 8, /* 0x20 - Enable USB0 in S5 */ S5U1, 8, /* 0x21 - Enable USB1 in S5 */ S3U0, 8, /* 0x22 - Enable USB0 in S3 */
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32953 )
Change subject: soc/intel/braswell/acpi/globalnvs.asl: Remove redundant use of Offset ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32953 )
Change subject: soc/intel/braswell/acpi/globalnvs.asl: Remove redundant use of Offset ......................................................................
soc/intel/braswell/acpi/globalnvs.asl: Remove redundant use of Offset
ASL compiler reports twice warning 'unnecessary/redundant use of Offfset operator'.
Remove redundant offsets.
BUG=N/A TEST=Facebook FBG-1701 booting Embedded Linux
Change-Id: I16705b9392b17c50d3988012406e03de393cbcd2 Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32953 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/soc/intel/braswell/acpi/globalnvs.asl 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/soc/intel/braswell/acpi/globalnvs.asl b/src/soc/intel/braswell/acpi/globalnvs.asl index c0b0b8d..9bd9afc 100644 --- a/src/soc/intel/braswell/acpi/globalnvs.asl +++ b/src/soc/intel/braswell/acpi/globalnvs.asl @@ -31,7 +31,6 @@ Field (GNVS, ByteAcc, NoLock, Preserve) { /* Miscellaneous */ - Offset (0x00), OSYS, 16, /* 0x00 - Operating System */ SMIF, 8, /* 0x02 - SMI function */ PRM0, 8, /* 0x03 - SMI function parameter */ @@ -55,7 +54,6 @@ CID1, 16, /* 0x1e - Wifi Domain Type */
/* Device Config */ - Offset (0x20), S5U0, 8, /* 0x20 - Enable USB0 in S5 */ S5U1, 8, /* 0x21 - Enable USB1 in S5 */ S3U0, 8, /* 0x22 - Enable USB0 in S3 */
-
Frans Hendriks (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)