Change in ...coreboot[master]: Remove the unused section of reef RO flash and give it to coreboot.
Mathew King has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31230
Change subject: Remove the unused section of reef RO flash and give it to coreboot. ......................................................................
Remove the unused section of reef RO flash and give it to coreboot.
BUG=chromium:903833,b:120086021 TEST=emerge-reef coreboot
Change-Id: Ie7a25c4638c474e81fb34b57de0dfc1bf393ea67 Signed-off-by: Mathew King mathewk@chromium.org --- M src/mainboard/google/reef/chromeos.fmd 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/31230/1
diff --git a/src/mainboard/google/reef/chromeos.fmd b/src/mainboard/google/reef/chromeos.fmd index 768d322..f601adc 100644 --- a/src/mainboard/google/reef/chromeos.fmd +++ b/src/mainboard/google/reef/chromeos.fmd @@ -7,9 +7,8 @@ FMAP@0x0 0x800 RO_FRID@0x800 0x40 RO_FRID_PAD@0x840 0x7c0 - COREBOOT(CBFS)@0x1000 0x17b000 - GBB@0x17c000 0x40000 - RO_UNUSED@0x1bc000 0x40000 + COREBOOT(CBFS)@0x1000 0x1bb000 + GBB@0x1bc000 0x40000 } } MISC_RW@0x400000 0x30000 {
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31230
to look at the new patch set (#2).
Change subject: Remove the unused section of reef RO flash and give it to coreboot. ......................................................................
Remove the unused section of reef RO flash and give it to coreboot.
BUG=chromium:903833 TEST=emerge-reef coreboot
Change-Id: Ie7a25c4638c474e81fb34b57de0dfc1bf393ea67 Signed-off-by: Mathew King mathewk@chromium.org --- M src/mainboard/google/reef/chromeos.fmd 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/31230/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31230 )
Change subject: Remove the unused section of reef RO flash and give it to coreboot. ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31230 )
Change subject: Remove the unused section of reef RO flash and give it to coreboot. ......................................................................
Patch Set 2:
(1 comment)
Looks good, but the commit message isn't formatted properly. I've suggested an alternative.
https://review.coreboot.org/#/c/31230/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31230/2//COMMIT_MSG@7 PS2, Line 7: Remove the unused section of reef RO flash and give it to coreboot. mb/google/reef: Allocate unused RO section
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31230 )
Change subject: Remove the unused section of reef RO flash and give it to coreboot. ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31230/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31230/2//COMMIT_MSG@8 PS2, Line 8: Why is it unused? Did something change or copy and paste mistake?
Please keep in mind, that most reviewers do not have access to the Chromium bug tracker.
Hello build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31230
to look at the new patch set (#3).
Change subject: mb/google/reef: Expand the coreboot RO section. ......................................................................
mb/google/reef: Expand the coreboot RO section.
Current coreboot size is not adequate for testing new features.
Note: This change is for testing at ToT only and should not be cherry-picked into reef's firmware branch.
BUG=chromium:903833 TEST=emerge-reef coreboot
Change-Id: Ie7a25c4638c474e81fb34b57de0dfc1bf393ea67 Signed-off-by: Mathew King mathewk@chromium.org --- M src/mainboard/google/reef/chromeos.fmd 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/31230/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31230 )
Change subject: mb/google/reef: Expand the coreboot RO section. ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/31230/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31230/3//COMMIT_MSG@7 PS3, Line 7: . Please do not put a full stop on the commit summary
https://review.coreboot.org/#/c/31230/3//COMMIT_MSG@11 PS3, Line 11: Note: This change is for testing at ToT only and should not be : cherry-picked into reef's firmware branch. I would recommend prepending the commit summary with something like [TESTONLY] for better visibility
Hello build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31230
to look at the new patch set (#4).
Change subject: [TESTONLY] mb/google/reef: Expand the coreboot RO section ......................................................................
[TESTONLY] mb/google/reef: Expand the coreboot RO section
Current coreboot size is not adequate for testing new features.
Note: This change is for testing at ToT only and should not be cherry-picked into reef's firmware branch.
BUG=chromium:903833 TEST=emerge-reef coreboot
Change-Id: Ie7a25c4638c474e81fb34b57de0dfc1bf393ea67 Signed-off-by: Mathew King mathewk@chromium.org --- M src/mainboard/google/reef/chromeos.fmd 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/31230/4
Martin Roth has uploaded a new patch set (#5) to the change originally created by Mathew King. ( https://review.coreboot.org/c/coreboot/+/31230 )
Change subject: mb/google/reef: Expand the coreboot RO section ......................................................................
mb/google/reef: Expand the coreboot RO section
Current coreboot size is not adequate for adding new features.
Note for cros: This change is for merge to ToT only and should not be cherry-picked into reef's firmware branch.
BUG=chromium:903833 TEST=emerge-reef coreboot
Change-Id: Ie7a25c4638c474e81fb34b57de0dfc1bf393ea67 Signed-off-by: Mathew King mathewk@chromium.org --- M src/mainboard/google/reef/chromeos.fmd 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/31230/5
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31230 )
Change subject: mb/google/reef: Expand the coreboot RO section ......................................................................
mb/google/reef: Expand the coreboot RO section
Current coreboot size is not adequate for adding new features.
Note for cros: This change is for merge to ToT only and should not be cherry-picked into reef's firmware branch.
BUG=chromium:903833 TEST=emerge-reef coreboot
Change-Id: Ie7a25c4638c474e81fb34b57de0dfc1bf393ea67 Signed-off-by: Mathew King mathewk@chromium.org Reviewed-on: https://review.coreboot.org/c/31230 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/reef/chromeos.fmd 1 file changed, 2 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/reef/chromeos.fmd b/src/mainboard/google/reef/chromeos.fmd index 768d322..f601adc 100644 --- a/src/mainboard/google/reef/chromeos.fmd +++ b/src/mainboard/google/reef/chromeos.fmd @@ -7,9 +7,8 @@ FMAP@0x0 0x800 RO_FRID@0x800 0x40 RO_FRID_PAD@0x840 0x7c0 - COREBOOT(CBFS)@0x1000 0x17b000 - GBB@0x17c000 0x40000 - RO_UNUSED@0x1bc000 0x40000 + COREBOOT(CBFS)@0x1000 0x1bb000 + GBB@0x1bc000 0x40000 } } MISC_RW@0x400000 0x30000 {
-
Angel Pons (Code Review) -
Furquan Shaikh (Code Review)
-
Martin Roth (Code Review)
-
Mathew King (Code Review)
-
Paul Menzel (Code Review)