Change in coreboot[master]: mb/goog/hatch: Initialize FPMCU_PCH_BOOT1

[Chen Wisley (Code Review)]

Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35845 )

Change subject: mb/goog/hatch: Initialize FPMCU_PCH_BOOT1
......................................................................

mb/goog/hatch: Initialize FPMCU_PCH_BOOT1

FPMCU_PCH_BOOT1 pin is connected to GPP_C12.
So, config GPP_C12.

BUG=b:142188003
TEST=emerge-hatch coreboot

Change-Id: I73a5c3529330ef3e72f4c7d5fcbbd2f6693494d8
Signed-off-by: Wisley Chen 
---
M src/mainboard/google/hatch/variants/dratini/gpio.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/35845/1

diff --git a/src/mainboard/google/hatch/variants/dratini/gpio.c b/src/mainboard/google/hatch/variants/dratini/gpio.c
index 003b7d1..30d56d7 100644
--- a/src/mainboard/google/hatch/variants/dratini/gpio.c
+++ b/src/mainboard/google/hatch/variants/dratini/gpio.c
@@ -31,6 +31,8 @@
    PAD_NC(GPP_A18, NONE),
    /* A19 : NC */
    PAD_NC(GPP_A19, NONE),
+	/* C12 : FPMCU_PCH_BOOT1 */
+	PAD_CFG_GPO(GPP_C12, 0, DEEP),
    /* C15 : NC */
    PAD_NC(GPP_C15, NONE),
    /* F1  : NC */

Change in coreboot[master]: mb/google/hatch: Initialize FPMCU_PCH_BOOT1

[Chen Wisley (Code Review)]

Hello Paul Fagerburg, Philip Chen, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35845

to look at the new patch set (#2).

Change subject: mb/google/hatch: Initialize FPMCU_PCH_BOOT1
......................................................................

mb/google/hatch: Initialize FPMCU_PCH_BOOT1

FPMCU_PCH_BOOT1 pin is connected to GPP_C12.
So, config GPP_C12.

BUG=b:142188003
TEST=emerge-hatch coreboot

Change-Id: I73a5c3529330ef3e72f4c7d5fcbbd2f6693494d8
Signed-off-by: Wisley Chen 
---
M src/mainboard/google/hatch/variants/dratini/gpio.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/35845/2

Change in coreboot[master]: mb/google/hatch: Initialize FPMCU_PCH_BOOT1

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35845 )

Change subject: mb/google/hatch: Initialize FPMCU_PCH_BOOT1
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: mb/google/hatch: Initialize FPMCU_PCH_BOOT1

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35845 )

Change subject: mb/google/hatch: Initialize FPMCU_PCH_BOOT1
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: mb/google/hatch: Initialize FPMCU_PCH_BOOT1

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35845 )

Change subject: mb/google/hatch: Initialize FPMCU_PCH_BOOT1
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35845/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35845/2//COMMIT_MSG@7 
PS2, Line 7: :
"mb/google/hatch/var/dratini: " since this change is being made for just one variant.

Tim/Paul -- can you please check if this change is required for other variants too? In that case it can be done in baseboard/gpio.c

Change in coreboot[master]: mb/google/hatch: Initialize FPMCU_PCH_BOOT1

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35845 )

Change subject: mb/google/hatch: Initialize FPMCU_PCH_BOOT1
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35845/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35845/2//COMMIT_MSG@7 
PS2, Line 7: :
> "mb/google/hatch/var/dratini: " since this change is being made for just one variant. […]

It looks like the pin just changed on dratini, it's GPP_A10 in the baseboard.

Change in coreboot[master]: mb/google/hatch: Initialize FPMCU_PCH_BOOT1

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35845 )

Change subject: mb/google/hatch: Initialize FPMCU_PCH_BOOT1
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35845/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35845/2//COMMIT_MSG@10 
PS2, Line 10: So, config GPP_C12.
Please use the full text width.

Change in coreboot[master]: mb/google/hatch: Initialize FPMCU_PCH_BOOT1

[Wisley Chen (Code Review)]

Wisley Chen has uploaded a new patch set (#3) to the change originally created by Chen Wisley. ( https://review.coreboot.org/c/coreboot/+/35845 )

Change subject: mb/google/hatch: Initialize FPMCU_PCH_BOOT1
......................................................................

mb/google/hatch: Initialize FPMCU_PCH_BOOT1

FPMCU_PCH_BOOT1 pin is connected to GPP_C12. So, config GPP_C12.

BUG=b:142188003
TEST=emerge-hatch coreboot

Change-Id: I73a5c3529330ef3e72f4c7d5fcbbd2f6693494d8
Signed-off-by: Wisley Chen 
---
M src/mainboard/google/hatch/variants/dratini/gpio.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/35845/3

Change in coreboot[master]: mb/google/hatch: Initialize FPMCU_PCH_BOOT1

[Wisley Chen (Code Review)]

Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35845 )

Change subject: mb/google/hatch: Initialize FPMCU_PCH_BOOT1
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35845/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35845/2//COMMIT_MSG@10 
PS2, Line 10: So, config GPP_C12.
> Please use the full text width.

Done

Change in coreboot[master]: mb/google/hatch: Initialize FPMCU_PCH_BOOT1

[Chen Wisley (Code Review)]

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35845 )

Change subject: mb/google/hatch: Initialize FPMCU_PCH_BOOT1
......................................................................

Patch Set 3:

Please help to merge the patch
thanks

Change in coreboot[master]: mb/google/hatch: Initialize FPMCU_PCH_BOOT1

[Shelley Chen (Code Review)]

Shelley Chen has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35845 )

Change subject: mb/google/hatch: Initialize FPMCU_PCH_BOOT1
......................................................................

mb/google/hatch: Initialize FPMCU_PCH_BOOT1

FPMCU_PCH_BOOT1 pin is connected to GPP_C12. So, config GPP_C12.

BUG=b:142188003
TEST=emerge-hatch coreboot

Change-Id: I73a5c3529330ef3e72f4c7d5fcbbd2f6693494d8
Signed-off-by: Wisley Chen 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35845
Reviewed-by: Paul Fagerburg 
Reviewed-by: Tim Wawrzynczak 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/hatch/variants/dratini/gpio.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Tim Wawrzynczak: Looks good to me, approved
  Paul Fagerburg: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/dratini/gpio.c b/src/mainboard/google/hatch/variants/dratini/gpio.c
index 003b7d1..30d56d7 100644
--- a/src/mainboard/google/hatch/variants/dratini/gpio.c
+++ b/src/mainboard/google/hatch/variants/dratini/gpio.c
@@ -31,6 +31,8 @@
    PAD_NC(GPP_A18, NONE),
    /* A19 : NC */
    PAD_NC(GPP_A19, NONE),
+	/* C12 : FPMCU_PCH_BOOT1 */
+	PAD_CFG_GPO(GPP_C12, 0, DEEP),
    /* C15 : NC */
    PAD_NC(GPP_C15, NONE),
    /* F1  : NC */