Attention is currently required from: Ashish Kumar Mishra, Deepti Deshatty, Shelley Chen, Vijay P Hiremath.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81207?usp=email )
Change subject: mb/google/brox: Enable PMC pins to work with PD
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81207/comment/6431911f_76e46687 :
PS1, Line 9: For PMC-PD communication we need to enable 3 pins.
These pins are configured based on HW team's brox sheet.
this information for SoC (about native function) is captured in it's datasheet (EDS in your case), there should be a table called "pin mux" or something similar in the datasheet which should have info on all the native functions of all GPIO. It would be good if you could mention Doc Number and revision of the EDS which has this info about native function in commit msg.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81207?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia678d291e7a14aefe09026e70478fea3f68c8e10
Gerrit-Change-Number: 81207
Gerrit-PatchSet: 2
Gerrit-Owner: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Vijay P Hiremath
vijay.p.hiremath@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Vijay P Hiremath
vijay.p.hiremath@intel.com
Gerrit-Attention: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Comment-Date: Thu, 28 Mar 2024 08:23:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Varshit Pandya
pandyavarshit@gmail.com
Comment-In-Reply-To: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Comment-In-Reply-To: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-MessageType: comment