Attention is currently required from: Furquan Shaikh, Subrata Banik, Patrick Rudolph, EricR Lai. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56074 )
Change subject: mb/google/brya: Add UsbTcPortEn in devicetree ......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/56074/comment/d5d6aee4_e914922f PS5, Line 309: s_cfg->UsbTcPortEn = 0; : for (int i = 0; i < MAX_TYPE_C_PORTS; i++) { : /* TCSS xHCI --> Root Hub --> Type-C Port */ : const struct device_path port_path[] = { : {.type = DEVICE_PATH_PCI, .pci.devfn = SA_DEVFN_TCSS_XHCI}, : {.type = DEVICE_PATH_USB, .usb.port_type = 0, .usb.port_id = 0}, : {.type = DEVICE_PATH_USB, .usb.port_type = 3, .usb.port_id = i} }; : const struct device *port = find_dev_nested_path(pci_root_bus(), port_path, : ARRAY_SIZE(port_path)); : : if (is_dev_enabled(port)) : s_cfg->UsbTcPortEn |= BIT(i); : } right here 😊