Change in coreboot[master]: soc/intel/common/intelblocks: Remove PAD_CFG_GPI_GPIO_DRIVER_SCI

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35460 )

Change subject: soc/intel/common/intelblocks: Remove PAD_CFG_GPI_GPIO_DRIVER_SCI
......................................................................

soc/intel/common/intelblocks: Remove PAD_CFG_GPI_GPIO_DRIVER_SCI

Intel's EDS says "1 = GPIO Driver Mode. GPIO input event updates are
limited to GPI_STS.  GPI_GPE_STS, GPI_NMI_STS and/or GPI_SMI_STS updates
are masked."  Therefore, the GPI_GPIO_DRIVER_SCI option for pad
configuration is meaningless, as any GPE will be masked if the GPIO
driver is set as owner.

Change-Id: Ia0cd0041dfc985cbe388cb89a4026038c7fb4383
Signed-off-by: Tim Wawrzynczak 
---
M src/soc/intel/common/block/include/intelblocks/gpio_defs.h
1 file changed, 0 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/35460/1

diff --git a/src/soc/intel/common/block/include/intelblocks/gpio_defs.h b/src/soc/intel/common/block/include/intelblocks/gpio_defs.h
index d46e404..15df187 100644
--- a/src/soc/intel/common/block/include/intelblocks/gpio_defs.h
+++ b/src/soc/intel/common/block/include/intelblocks/gpio_defs.h
@@ -411,13 +411,6 @@
    	PAD_IOSSTATE(TxDRxE))

#if CONFIG(SOC_INTEL_COMMON_BLOCK_GPIO_DUAL_ROUTE_SUPPORT)
-/* GPI, GPIO Driver, SCI interrupt */
-#define PAD_CFG_GPI_GPIO_DRIVER_SCI(pad, pull, rst, trig, inv)	\
-	_PAD_CFG_STRUCT(pad,		\
-		PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_BUF(TX_DISABLE) | \
-			PAD_IRQ_CFG(SCI, trig, inv),	\
-		PAD_PULL(pull) | PAD_CFG1_GPIO_DRIVER | PAD_IOSSTATE(TxDRxE))
-
 #define PAD_CFG_GPI_DUAL_ROUTE(pad, pull, rst, trig, inv, route1, route2) \
    _PAD_CFG_STRUCT(pad,						\
    	PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_BUF(TX_DISABLE) | \

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35460 )

Change subject: soc/intel/common/intelblocks: Remove PAD_CFG_GPI_GPIO_DRIVER_SCI
......................................................................

Patch Set 1: Code-Review+1

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35460 )

Change subject: soc/intel/common/intelblocks: Remove PAD_CFG_GPI_GPIO_DRIVER_SCI
......................................................................

Patch Set 1: Code-Review+2