Attention is currently required from: Ana Carolina Cabral.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/87019?usp=email )
Change subject: util/amdfwtool: Move needs_ish and combo_new_rab to data_parse.c
......................................................................
Patch Set 2:
(1 comment)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/87019/comment/6f98a897_0224894e?usp... :
PS1, Line 814: cb_config
'cb_config' is a pointer; did you mean to use '->'?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87019?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib609d967e23b4ca1937e00ec72a669751ef09714
Gerrit-Change-Number: 87019
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ana Carolina Cabral
ana.cpmelo95@gmail.com
Gerrit-Attention: Ana Carolina Cabral
ana.cpmelo95@gmail.com
Gerrit-Comment-Date: Wed, 02 Apr 2025 18:19:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ana Carolina Cabral
ana.cpmelo95@gmail.com