Attention is currently required from: Sam McNally, Furquan Shaikh, Tony Huang, Tim Wawrzynczak, Keith Tzeng, Wisley Chen.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52725 )
Change subject: mb/google/puff/var/dooly: enable touchscreen wakeup
......................................................................
Patch Set 9: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52725/comment/8a1d92a2_01dbdfec
PS9, Line 11: Add fake touchscreen enable_pin GPP_D9 to ensure meet power sequence T11 in spec v0.8.
How? What is spec v0.8 can you elaborate with more detail here please?
https://review.coreboot.org/c/coreboot/+/52725/comment/5f5bfa31_dac07b0d
PS9, Line 13: empty pin
when you say "empty" do you mean NC or do you mean GND plane? I assume you mean NC but I wanted to check?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52725
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bbaab56924849a22a4d05ce53bf5bdcf00265dd
Gerrit-Change-Number: 52725
Gerrit-PatchSet: 9
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Attention: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 03 May 2021 12:04:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment