Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33422 )
Change subject: utils/inteltool: Do more refactoring
......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33422/6/util/inteltool/inteltool.h
File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/33422/6/util/inteltool/inteltool.h@...
PS6, Line 387: vo
Not sure if declaring this function is needed
https://review.coreboot.org/c/coreboot/+/33422/6/util/inteltool/inteltool.c
File util/inteltool/inteltool.c:
https://review.coreboot.org/c/coreboot/+/33422/6/util/inteltool/inteltool.c@...
PS6, Line 660:
How do you handle multiple devices now?
https://review.coreboot.org/c/coreboot/+/33422/6/util/inteltool/inteltool.c@...
PS6, Line 703:
This distinction is now lost.
https://review.coreboot.org/c/coreboot/+/33422/6/util/inteltool/inteltool.c@...
PS6, Line 696: {
That's not coreboot code style, and it doesn't match the rest of the file's style now
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33422
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb0c6953aee1ace275206fa4a2c16fa477bad5ec
Gerrit-Change-Number: 33422
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Marius Genheimer
mail@f0wl.cc
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 18 Aug 2019 22:02:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment