Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80399?usp=email )
Change subject: Makefile: Drop unused variable originalobjs ......................................................................
Makefile: Drop unused variable originalobjs
This was added in commit 963bed546f (Make: Use unaltered object list for dependency inclusion) to fix an issue caused by ramstage-postprocess. The logic for handling dependency inclusion changed in commit db273065f6 (build system: extend src-to-obj for non-.c/.S files), causing the variable to become unused.
Change-Id: I011ff2070bc31ab9ddf2536873555d0157f91fce Signed-off-by: Nicholas Chin nic.c3.14@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/80399 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin L Roth gaumless@gmail.com Reviewed-by: Nico Huber nico.h@gmx.de --- M Makefile 1 file changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved Nico Huber: Looks good to me, but someone else must approve
diff --git a/Makefile b/Makefile index 412d6a6..fddcc5c 100644 --- a/Makefile +++ b/Makefile @@ -363,9 +363,6 @@ # For Ada includes $(foreach class,$(classes),$(eval $(class)-ada-dirs:=$(sort $(dir $(filter %.ads %.adb,$($(class)-srcs)) $($(class)-extra-specs)))))
-# Save all objs before processing them (for dependency inclusion) -originalobjs:=$(foreach var, $(addsuffix -objs,$(classes)), $($(var))) - # Call post-processors if they're defined $(foreach class,$(classes),\ $(if $(value $(class)-postprocess),$(eval $(call $(class)-postprocess,$($(class)-objs)))))