Change in coreboot[master]: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support

[huayang duan (Code Review)]

huayang duan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support

BUG=b:80501386
BRANCH=none
TEST=Boots correctly and stress test pass on Kukui.

Change-Id: I27164f0909edb9d9398835e292fb845f0e342391
Signed-off-by: Huayang Duan 
---
M src/mainboard/google/kukui/sdram_configs.c
M src/mainboard/google/kukui/sdram_params/Makefile.inc
A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB.c
3 files changed, 43 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/34532/1

diff --git a/src/mainboard/google/kukui/sdram_configs.c b/src/mainboard/google/kukui/sdram_configs.c
index 5931c79..8b9e830 100644
--- a/src/mainboard/google/kukui/sdram_configs.c
+++ b/src/mainboard/google/kukui/sdram_configs.c
@@ -19,6 +19,7 @@
 #include <soc/emi.h>

static const char *const sdram_configs[] = {
+	[0] = "sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB",
    [1] = "sdram-lpddr4x-H9HCNNNCPMALHR-4GB",
    [2] = "sdram-lpddr4x-MT53E1G32D4NQ-4GB",
    [3] = "sdram-lpddr4x-KMDP6001DA-B425-4GB",
diff --git a/src/mainboard/google/kukui/sdram_params/Makefile.inc b/src/mainboard/google/kukui/sdram_params/Makefile.inc
index 77158a5..bac5279 100644
--- a/src/mainboard/google/kukui/sdram_params/Makefile.inc
+++ b/src/mainboard/google/kukui/sdram_params/Makefile.inc
@@ -1,4 +1,5 @@
 sdram-params :=
+sdram-params += sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB
 sdram-params += sdram-lpddr4x-H9HCNNNCPMALHR-4GB
 sdram-params += sdram-lpddr4x-MT53E1G32D4NQ-4GB
 sdram-params += sdram-lpddr4x-KMDP6001DA-B425-4GB
diff --git a/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB.c b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB.c
new file mode 100644
index 0000000..5531a7f
--- /dev/null
+++ b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB.c
@@ -0,0 +1,41 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2018 MediaTek Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <soc/emi.h>
+
+struct sdram_params params = {
+	.impedance = {
+		[ODT_OFF] = {0x9, 0x7, 0x0, 0xF},
+		[ODT_ON] = {0x10, 0x9, 0x0, 0xE}
+	},
+	.wr_level = {
+		[CHANNEL_A] = { {0x22, 0x1C}, {0x23, 0x1D} },
+		[CHANNEL_B] = { {0x22, 0x1E}, {0x25, 0x22} }
+	},
+	.cbt_cs = {
+		[CHANNEL_A] = {0x6, 0x5},
+		[CHANNEL_B] = {0x6, 0x6}
+	},
+	.cbt_mr12 = {
+		[CHANNEL_A] = {0x56, 0x58},
+		[CHANNEL_B] = {0x58, 0x56}
+	},
+	.emi_cona_val = 0xF053F154,
+	.emi_conh_val = 0x44440003,
+	.emi_conf_val = 0x00421000,
+	.chn_emi_cona_val = {0x0444F051, 0x0444F051},
+	.cbt_mode_extern = CBT_NORMAL_MODE,
+	.delay_cell_unit = 868,
+};

[huayang duan (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34532

to look at the new patch set (#2).

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support

BUG=b:80501386
BRANCH=none
TEST=Boots correctly and stress test pass on Kukui.

Change-Id: I27164f0909edb9d9398835e292fb845f0e342391
Signed-off-by: Huayang Duan 
---
M src/mainboard/google/kukui/sdram_configs.c
M src/mainboard/google/kukui/sdram_params/Makefile.inc
A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB.c
3 files changed, 43 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/34532/2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

Patch Set 2: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/34532/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34532/2//COMMIT_MSG@11 
PS2, Line 11: pass
passes

[huayang duan (Code Review)]

huayang duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34532/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34532/2//COMMIT_MSG@11 
PS2, Line 11: pass
> passes

Does ‘Boots correctly and passed stress test on kukui’ better to 'Boots correctly and stress test passes on Kukui' ?

[You-Cheng Syu (Code Review)]

You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34532/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34532/2//COMMIT_MSG@11 
PS2, Line 11: pass
> Does ‘Boots correctly and passed stress test on kukui’ better to 'Boots correctly and stress test pa […]

probably not

[Yu-Ping Wu (Code Review)]

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

Patch Set 2: Code-Review+1

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

Patch Set 2: Code-Review+2

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

Patch Set 2: Code-Review-1

(1 comment)

Please do not submit this yet - the RAM ID may be wrong.

https://review.coreboot.org/c/coreboot/+/34532/2/src/mainboard/google/kukui/... 
File src/mainboard/google/kukui/sdram_configs.c:

https://review.coreboot.org/c/coreboot/+/34532/2/src/mainboard/google/kukui/... 
PS2, Line 22: 0]
Hi @MTK, in Kukui RAM ID table this should  be 8 instead of 0.

Can you double check with your hardware team?

[Peichao Li (Code Review)]

Peichao Li has uploaded a new patch set (#3) to the change originally created by huayang duan. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support

BUG=b:80501386
BRANCH=none
TEST=Boots correctly and stress test pass on Kukui.

Change-Id: I27164f0909edb9d9398835e292fb845f0e342391
Signed-off-by: Huayang Duan 
---
M src/mainboard/google/kukui/sdram_configs.c
M src/mainboard/google/kukui/sdram_params/Makefile.inc
A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB.c
3 files changed, 43 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/34532/3

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

Patch Set 3: Code-Review+2

The ID is now correct. Thanks.

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34532/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34532/2//COMMIT_MSG@11 
PS2, Line 11: pass
> probably not

Ack

https://review.coreboot.org/c/coreboot/+/34532/2/src/mainboard/google/kukui/... 
File src/mainboard/google/kukui/sdram_configs.c:

https://review.coreboot.org/c/coreboot/+/34532/2/src/mainboard/google/kukui/... 
PS2, Line 22: 0]
> Hi @MTK, in Kukui RAM ID table this should  be 8 instead of 0. […]

Ack

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#4) to the change originally created by huayang duan. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support

BUG=b:80501386
BRANCH=none
TEST=Boots correctly and stress test passes on Kukui.

Change-Id: I27164f0909edb9d9398835e292fb845f0e342391
Signed-off-by: Huayang Duan 
---
M src/mainboard/google/kukui/sdram_configs.c
M src/mainboard/google/kukui/sdram_params/Makefile.inc
A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB.c
3 files changed, 43 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/34532/4

[Huayang Duan (Code Review)]

Huayang Duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34532/2/src/mainboard/google/kukui/... 
File src/mainboard/google/kukui/sdram_configs.c:

https://review.coreboot.org/c/coreboot/+/34532/2/src/mainboard/google/kukui/... 
PS2, Line 22: 0]
> Ack

you are right, I have confirme this with hardware team, the RAM ID of K4UBE3D4AA-MGCL should be 8, not 0.

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

Patch Set 5: Code-Review+2

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

Patch Set 5:

seems like rebasing made my +2 useless. @jwerner are you ok to give some blessing?

[Yu-Ping Wu (Code Review)]

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34532/5/src/mainboard/google/kukui/... 
File src/mainboard/google/kukui/sdram_params/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/34532/5/src/mainboard/google/kukui/... 
PS5, Line 2: sdram-params += sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB
Move this to the end for consistency with the source code.

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

Patch Set 5: Code-Review+2
> seems like rebasing made my +2 useless. @jwerner are you ok to give some blessing?

Yeah, our new commit restriction rules are a little annoying at times...

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

Patch Set 5: Code-Review+2

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

Patch Set 5:

Please make sure all the comments are resolved so this can be merged.

[Peichao Li (Code Review)]

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

Patch Set 5:

(3 comments)

https://review.coreboot.org/c/coreboot/+/34532/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34532/2//COMMIT_MSG@11 
PS2, Line 11: pass
> Ack

Done

https://review.coreboot.org/c/coreboot/+/34532/2/src/mainboard/google/kukui/... 
File src/mainboard/google/kukui/sdram_configs.c:

https://review.coreboot.org/c/coreboot/+/34532/2/src/mainboard/google/kukui/... 
PS2, Line 22: 0]
> you are right, I have confirme this with hardware team, the RAM ID of K4UBE3D4AA-MGCL should be 8, n […]

Done

https://review.coreboot.org/c/coreboot/+/34532/5/src/mainboard/google/kukui/... 
File src/mainboard/google/kukui/sdram_params/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/34532/5/src/mainboard/google/kukui/... 
PS5, Line 2: sdram-params += sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB
> Move this to the end for consistency with the source code.

Done

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

Patch Set 5:

this looks ok. ready for merge?

[Huayang Duan (Code Review)]

Huayang Duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

Patch Set 5: Code-Review+2
> Patch Set 5:
>
> this looks ok. ready for merge?

It's ok for me

[Julius Werner (Code Review)]

Julius Werner has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34532 )

Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support
......................................................................

mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support

BUG=b:80501386
BRANCH=none
TEST=Boots correctly and stress test passes on Kukui.

Change-Id: I27164f0909edb9d9398835e292fb845f0e342391
Signed-off-by: Huayang Duan 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34532
Reviewed-by: Hung-Te Lin 
Reviewed-by: Julius Werner 
Reviewed-by: Martin Roth 
Reviewed-by: Huayang Duan 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/kukui/sdram_configs.c
M src/mainboard/google/kukui/sdram_params/Makefile.inc
A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB.c
3 files changed, 43 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved
  Julius Werner: Looks good to me, approved
  Hung-Te Lin: Looks good to me, approved
  Huayang Duan: Looks good to me, approved

diff --git a/src/mainboard/google/kukui/sdram_configs.c b/src/mainboard/google/kukui/sdram_configs.c
index d8b3cc4..b6277ea 100644
--- a/src/mainboard/google/kukui/sdram_configs.c
+++ b/src/mainboard/google/kukui/sdram_configs.c
@@ -26,6 +26,7 @@
    [5] = "sdram-lpddr4x-MT29VZZZAD8DQKSL-4GB",
    [6] = "sdram-lpddr4x-KMDV6001DA-B620-4GB",
    [7] = "sdram-lpddr4x-SDADA4CR-128G-4GB",
+	[8] = "sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB",
 };

static struct sdram_params params;
diff --git a/src/mainboard/google/kukui/sdram_params/Makefile.inc b/src/mainboard/google/kukui/sdram_params/Makefile.inc
index fbc505b..4d91998 100644
--- a/src/mainboard/google/kukui/sdram_params/Makefile.inc
+++ b/src/mainboard/google/kukui/sdram_params/Makefile.inc
@@ -1,4 +1,5 @@
 sdram-params :=
+sdram-params += sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB
 sdram-params += sdram-lpddr4x-H9HCNNNCPMALHR-4GB
 sdram-params += sdram-lpddr4x-MT53E1G32D4NQ-4GB
 sdram-params += sdram-lpddr4x-KMDH6001DA-B422-4GB
diff --git a/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB.c b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB.c
new file mode 100644
index 0000000..8d855ff
--- /dev/null
+++ b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB.c
@@ -0,0 +1,41 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2018 MediaTek Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <soc/emi.h>
+
+struct sdram_params params = {
+	.impedance = {
+		[ODT_OFF] = {0x9, 0x7, 0x0, 0xF},
+		[ODT_ON] = {0xB, 0x9, 0x0, 0xE}
+	},
+	.wr_level = {
+		[CHANNEL_A] = { {0x22, 0x1C}, {0x23, 0x1D} },
+		[CHANNEL_B] = { {0x26, 0x23}, {0x26, 0x23} }
+	},
+	.cbt_cs = {
+		[CHANNEL_A] = {0x6, 0x5},
+		[CHANNEL_B] = {0x6, 0x6}
+	},
+	.cbt_mr12 = {
+		[CHANNEL_A] = {0x56, 0x58},
+		[CHANNEL_B] = {0x58, 0x56}
+	},
+	.emi_cona_val = 0xF053F154,
+	.emi_conh_val = 0x44440003,
+	.emi_conf_val = 0x00421000,
+	.chn_emi_cona_val = {0x0444F051, 0x0444F051},
+	.cbt_mode_extern = CBT_NORMAL_MODE,
+	.delay_cell_unit = 868,
+};